Fix/html comment newline 1823#2438
Open
SarthakDudhe wants to merge 3 commits into
Open
Conversation
…rray_indentation are enabled (beautifier#2010)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix: prevent comments without leading spaces from forcing newlines (#1823)
Description: This PR fixes an issue where HTML comments like (no leading space) were forced to a new line when following a closing tag, while (with space) remained on the same line.
The fix involves updating the comment identification logic in the HTML beautifier to use a prefix check instead of an exact string match. This ensures consistent behavior for all HTML comments.