fix: restore indent level after LESS each() mixin #2380#2441
Open
Anton-dev3306 wants to merge 1 commit into
Open
fix: restore indent level after LESS each() mixin #2380#2441Anton-dev3306 wants to merge 1 commit into
Anton-dev3306 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2380
Problem
After a LESS
each()mixin call using object notation (});), thebeautifier zeroed the indent level for all subsequent rules, even when
still inside a parent block.
Root cause: the
}handler callsoutdent(), then when the next charis
),trim(true)pops the newline — leavingcurrent_lineat theprevious (shallower) indent. The
{opening the mixin body (precededby
,) skipsindent(), so the net result is one extraoutdent().Fix
Added
this.indent()/self.indent()aftertrim(true)in thepeek() === ')'branch to compensate for the asymmetry.Both JS and Python implementations updated.
Verification
Input:
Before fix:
After fix: