From 411648ed91de9203eb1ef16a5b12ba33dbd39121 Mon Sep 17 00:00:00 2001 From: mvlassis Date: Thu, 25 Jun 2026 12:07:35 +0300 Subject: [PATCH 1/2] fix: increase retry period for validate_profile_deployments_with_custom_images --- .../tests/integration/test_charm_ambient.py | 4 +++- .../tests/integration/test_charm_object_storage.py | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/charms/kfp-profile-controller/tests/integration/test_charm_ambient.py b/charms/kfp-profile-controller/tests/integration/test_charm_ambient.py index 889a9f8f..7e94e42f 100644 --- a/charms/kfp-profile-controller/tests/integration/test_charm_ambient.py +++ b/charms/kfp-profile-controller/tests/integration/test_charm_ambient.py @@ -326,9 +326,11 @@ def validate_profile_resources( assert expected_label_value == namespace.metadata.labels[expected_label] +# Retry for 90 seconds since the metacontroller's `resyncPeriodSeconds` is +# currently 60s, so at worst it will take 60s for the resync to be triggered. @retry( wait=wait_exponential(multiplier=1, min=1, max=10), - stop=stop_after_delay(60), + stop=stop_after_delay(90), reraise=True, ) def validate_profile_deployments_with_custom_images( diff --git a/charms/kfp-profile-controller/tests/integration/test_charm_object_storage.py b/charms/kfp-profile-controller/tests/integration/test_charm_object_storage.py index 2968d54e..b2d496b4 100644 --- a/charms/kfp-profile-controller/tests/integration/test_charm_object_storage.py +++ b/charms/kfp-profile-controller/tests/integration/test_charm_object_storage.py @@ -232,9 +232,11 @@ def validate_profile_resources( assert expected_label_value == namespace.metadata.labels[expected_label] +# Retry for 90 seconds since the metacontroller's `resyncPeriodSeconds` is +# currently 60s, so at worst it will take 60s for the resync to be triggered. @retry( wait=wait_exponential(multiplier=1, min=1, max=10), - stop=stop_after_delay(60), + stop=stop_after_delay(90), reraise=True, ) def validate_profile_deployments_with_custom_images( From 890c3fa78d53b8c4b9448a010653289fd6e816fd Mon Sep 17 00:00:00 2001 From: mvlassis Date: Wed, 1 Jul 2026 14:52:15 +0300 Subject: [PATCH 2/2] Update tests --- .../kfp-profile-controller/tests/integration/test_charm_s3.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/charms/kfp-profile-controller/tests/integration/test_charm_s3.py b/charms/kfp-profile-controller/tests/integration/test_charm_s3.py index e638ecbd..66f2c247 100644 --- a/charms/kfp-profile-controller/tests/integration/test_charm_s3.py +++ b/charms/kfp-profile-controller/tests/integration/test_charm_s3.py @@ -321,9 +321,11 @@ def validate_profile_resources( assert expected_label_value == namespace.metadata.labels[expected_label] +# Retry for 90 seconds since the metacontroller's `resyncPeriodSeconds` is +# currently 60s, so at worst it will take 60s for the resync to be triggered. @retry( wait=wait_exponential(multiplier=1, min=1, max=10), - stop=stop_after_delay(60), + stop=stop_after_delay(90), reraise=True, ) def validate_profile_deployments_with_custom_images(