--dry-run [confirm] is interactive - should it be?

[bluefing]

Hi,

I was surprised to see that --dry-run on a [confirm] script prompts the user.

Is that expected?

--dry-run --yes resolves the 'issue' (if it is an issue).

I wasn't expecting dry run to be interactive.

[casey]

Thanks for reporting this! I could see this going either way.

An argument for making --dry-run imply --yes is that you don't need confirmation if you're only doing a dry run.

A argument for making them separate is that if you run something with --dry-run, not get a confirmation because it implies --yes, and then get a confirmation prompt when you later run it without --ry-run, you might be surprised.

I opened a draft PR that makes --dry-run imply --yes in #3294, but I'm not sure I'm going to merge it, since I could see the argument going either way.

[bluefing]

Makes sense, i think your instinct is right. it was just surprising.

An argument for leaving it the way it is, is that there is a simple workaround. The opposite is not true.

[casey]

Good point that there's no workaround to get the other behavior if you change it. I'm going to go ahead and close the branch.