Skip to content

fix(flow/retriever/parent): validate ParentIDKey is non-empty in NewRetriever #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(flow/retriever/parent): validate ParentIDKey is non-empty in NewRetriever #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flow/retriever/parent/parent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ func NewRetriever(ctx context.Context, config *Config) (retriever.Retriever, err
if config.OrigDocGetter == nil {
return nil, fmt.Errorf("orig doc getter is required")
}
if config.ParentIDKey == "" {
return nil, fmt.Errorf("parent id key is required")
}
return &parentRetriever{
retriever: config.Retriever,
parentIDKey: config.ParentIDKey,
Expand Down
21 changes: 21 additions & 0 deletions flow/retriever/parent/parent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,27 @@ func (t *testRetriever) Retrieve(ctx context.Context, query string, opts ...retr
return ret, nil
}

func TestNewRetrieverValidation(t *testing.T) {
ctx := context.Background()
tr := &testRetriever{}
getter := func(ctx context.Context, ids []string) ([]*schema.Document, error) { return nil, nil }

_, err := NewRetriever(ctx, &Config{Retriever: nil, ParentIDKey: "k", OrigDocGetter: getter})
if err == nil {
t.Error("expected error when Retriever is nil")
}

_, err = NewRetriever(ctx, &Config{Retriever: tr, ParentIDKey: "k", OrigDocGetter: nil})
if err == nil {
t.Error("expected error when OrigDocGetter is nil")
}

_, err = NewRetriever(ctx, &Config{Retriever: tr, ParentIDKey: "", OrigDocGetter: getter})
if err == nil {
t.Error("expected error when ParentIDKey is empty")
}
}

func TestParentRetriever(t *testing.T) {
tests := []struct {
name string
Expand Down