Skip to content

feat(server): Add messageThreadId handling in super groups for Telegram notifications #5409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AliArtukov wants to merge 6 commits into
base: master
Choose a base branch
from
+20 −4
Open

feat(server): Add messageThreadId handling in super groups for Telegram notifications #5409

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a84b8af
Add messageThreadId for Telegram notifications
AliArtukov Jun 2, 2026
7e91ea8
Refactor TelegramNotifier messageThreadId handling
AliArtukov Jun 2, 2026
353bed5
Merge branch 'master' into patch-1
AliArtukov Jun 2, 2026
1541313
Update buildUrl method to include message_thread_id
AliArtukov Jun 2, 2026
866e868
Change messageThreadId type from String to Integer
AliArtukov Jun 2, 2026
19154c0
Merge branch 'master' into patch-1
ulischulte Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions ...-admin-server/src/main/java/de/codecentric/boot/admin/server/notify/TelegramNotifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ public class TelegramNotifier extends AbstractContentNotifier {
*/
@Nullable private String chatId;

/**
* Unique identifier for the target topic of the target super group
*/
private Integer messageThreadId;

@cdprete cdprete Jun 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark it with @Nullable for consistency.


/**
* The token identifying und authorizing your Telegram bot (e.g.
* `123456:ABC-DEF1234ghIkl-zyx57W2v1u123ew11`)
Expand Down Expand Up @@ -75,14 +80,17 @@ protected Mono<Void> doNotify(InstanceEvent event, Instance instance) {
.fromRunnable(() -> restTemplate.getForObject(buildUrl(), Void.class, createMessage(event, instance)));
}

protected String buildUrl() {
return String.format("%s/bot%s/sendmessage?chat_id={chat_id}&text={text}&parse_mode={parse_mode}"
+ "&disable_notification={disable_notification}", this.apiUrl, this.authToken);
}
protected String buildUrl() {

@ulischulte ulischulte Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing tests verify exact URL strings and parameter map contents. Adding messageThreadId will change behavior that the tests should cover. Two test cases are needed:

  • When messageThreadId is set: URL includes &message_thread_id=... and parameter map contains the value
  • When messageThreadId is NOT set (default): URL does NOT include message_thread_id and parameter map does NOT contain it (backward compatibility)

return String.format(

@ulischulte ulischulte Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only include the parameter when messageThreadId != null.

Otherwise the message_thread_id parameter is always appended to the URL. You could pass null to the Telegram API (undefined behavior, likely a 400 error), or cause an NPE if Spring's UriComponentsBuilder tries to resolve {message_thread_id} with a null map value.

"%s/bot%s/sendmessage?chat_id={chat_id}&message_thread_id={message_thread_id}&text={text}&parse_mode={parse_mode}&disable_notification={disable_notification}",
this.apiUrl, this.authToken
);
}

private Map<String, Object> createMessage(InstanceEvent event, Instance instance) {
Map<String, Object> parameters = new HashMap<>();
parameters.put("chat_id", this.chatId);
parameters.put("message_thread_id", this.messageThreadId);

@ulischulte ulischulte Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
parameters.put("message_thread_id", this.messageThreadId);
if (this.messageThreadId != null) {
parameters.put("message_thread_id", this.messageThreadId);
}

This matches the Telegram Bot API specification where message_thread_id is explicitly documented as optional.

parameters.put("parse_mode", this.parseMode);
parameters.put("disable_notification", this.disableNotify);
parameters.put("text", createContent(event, instance));
Expand Down Expand Up @@ -114,6 +122,14 @@ public void setChatId(@Nullable String chatId) {
this.chatId = chatId;
}

public Integer getMessageThreadId() {
return messageThreadId;
}

public void setMessageThreadId(Integer messageThreadId) {
this.messageThreadId = messageThreadId;
}

@Nullable public String getAuthToken() {
return authToken;
}
Expand Down