From b59674e4e32d8a9e4794e0f05b6a4ebe7e7bb6ac Mon Sep 17 00:00:00 2001 From: Felipe Zipitria Date: Sun, 5 Jul 2026 21:42:55 +0200 Subject: [PATCH] fix: remove comment from bake-action set input MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit docker/bake-action's set input is a plain newline-separated list of target.key=value overrides, not YAML — it doesn't understand '#' comments on their own line. The explanatory comment added in #447 was fed straight into `docker buildx bake --set`, which failed to parse it and broke every build job in release/20260705: cannot parse bake definitions: ERROR: invalid override key # don't push tags; ..., expected target.name Moved the explanation to a real YAML comment above the step instead. --- .github/workflows/publish.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 56f7767..47bb5e4 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -104,6 +104,9 @@ jobs: repo="$(jq -r --arg t "${TARGET}" '.target[$t].tags[0] | split(":")[0]' bake-metadata.json)" echo "repo=${repo}" >> "${GITHUB_OUTPUT}" + # tags= clears the target's tags so this per-platform build doesn't push them; we tag + # everything at the end in the merge job, once all architectures have been built, to + # avoid a race condition where only the last-built platform would keep the tag - name: 'Build and push ${{ matrix.target }} (${{ matrix.platform }}) by digest' id: build-and-push uses: docker/bake-action@3acf805d94d93a86cce4ca44798a76464a75b88c # docker/bake-action@v6.9.0 @@ -113,8 +116,6 @@ jobs: targets: ${{ matrix.target }} set: | ${{ matrix.target }}.platform=${{ matrix.platform }} - # don't push tags; we do that at the end when all architectures have been built to - # avoid a race condition, where only the last built image would be tagged ${{ matrix.target }}.tags= ${{ matrix.target }}.output=type=image,name=${{ steps.repo.outputs.repo }},push-by-digest=true,name-canonical=true,push=true provenance: true