Skip to content

Commit 351bcaf

Browse files
Keep the importance trial's D arm rendering every reference with its score
The new production block renderer hides scores on the recent references, so rendering D one reference at a time through it dropped every score and broke the E arm's check. The trial now uses the per-compartment renderer with scores on, which is how D was actually run. Co-authored-by: Alfonso <alfonso-magic-context@users.noreply.github.com>
1 parent d55bb08 commit 351bcaf

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎packages/plugin/scripts/importance-anchoring-trial/core.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { createHash } from "node:crypto";
2-
import { renderSessionReferencesBlock, selectSeeds, type ReferenceCompartment } from "../../src/hooks/magic-context/reference-retrieval";
2+
import { renderSessionRefCompartment, selectSeeds, type ReferenceCompartment } from "../../src/hooks/magic-context/reference-retrieval";
33
import { REFERENCE_SEEDS } from "../../src/hooks/magic-context/reference-seeds.generated";
44
import { isNoContentCompartment } from "../../src/features/magic-context/no-content-compartment";
55

@@ -59,9 +59,9 @@ export function selectD(history: HistoricalReference[], session: string, start:
5959
}
6060
export function variantD(prompt: string, history: HistoricalReference[], session: string, start: number) {
6161
const selected = selectD(history, session, start);
62-
// The production renderer caps a whole block at six. Render one at a time
63-
// to preserve its escaping/tier behavior while admitting D's seven refs.
64-
const body = selected.references.map(c => renderSessionReferencesBlock([c]).replace(/^<session_references>\n|\n<\/session_references>$/g, "")).join("\n\n");
62+
// D as trialled showed importance on all seven references. Render each with
63+
// the production per-compartment renderer (escaping and tiers), scores on.
64+
const body = selected.references.map(c => renderSessionRefCompartment(c, true)).join("\n\n");
6565
const seeds = `<compartment_examples_from_other_projects>\n${selected.seeds.map(s => s.block).join("\n\n")}\n</compartment_examples_from_other_projects>`;
6666
// Callback replacement preserves literal $& / $` strings in historical code.
6767
return { prompt: prompt.replace(/<compartment_examples_from_other_projects>[\s\S]*?<\/compartment_examples_from_other_projects>/, () => seeds).replace(/<session_references>[\s\S]*?<\/session_references>/, () => `<session_references>\n${body}\n</session_references>`), selected };

‎packages/plugin/src/hooks/magic-context/reference-retrieval.ts‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,10 @@ export function renderSeedExamplesBlock(seeds: ReferenceSeed[]): string {
153153
* tiers) fall back to flat `content`. Keep episode_type in both groups, but
154154
* show importance only on diverse examples: newest scores cause anchoring.
155155
*/
156-
function renderSessionRefCompartment(c: ReferenceCompartment, showImportance: boolean): string {
156+
export function renderSessionRefCompartment(
157+
c: ReferenceCompartment,
158+
showImportance: boolean,
159+
): string {
157160
const importance = c.importance ?? 50;
158161
const attrs =
159162
`start="${c.startMessage}" end="${c.endMessage}" title="${escapeXmlAttr(c.title)}"` +

0 commit comments

Comments
 (0)