Avoid duplicated tokens when using minimize spread token strategy#7537
Closed
alexqyle wants to merge 1 commit into
Closed
Avoid duplicated tokens when using minimize spread token strategy#7537alexqyle wants to merge 1 commit into
alexqyle wants to merge 1 commit into
Conversation
Signed-off-by: Alex Le <leqiyue@amazon.com>
Contributor
|
We should take a look on why the resolveConflicts is not working for this situations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
When using minimize spread token strategy, there is a chance that multiple ingesters would have duplicated tokens if they are joining the ring around the same time.
The fix here is to pick multiple token candidates with largest distance and pick one to split based on instance name hash to avoid multiple instances got exactly same token.
Which issue(s) this PR fixes:
NA
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags