Skip to content

Fix SyntaxError during installation of datacontract-cli#1384

Merged
jschoedl merged 2 commits into
datacontract:mainfrom
Cupprum:main
Jul 21, 2026
Merged

Fix SyntaxError during installation of datacontract-cli#1384
jschoedl merged 2 commits into
datacontract:mainfrom
Cupprum:main

Conversation

@Cupprum

@Cupprum Cupprum commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

fixes the/path/to/datacontract/lint/resolve.py:72: SyntaxWarning: 'return' in a 'finally' block

  • Tests pass (uv run pytest) -> I am running in a corporate environemnt in devcontainer, so the tests about docker fail of course, but the rest works fine
  • Code formatted (uv run ruff check --fix && uv run ruff format)
  • Docs updated (if relevant) -> we are fixing syntax error, i dont think we need to update docs
  • CHANGELOG.md entry added

Samuel Branisa added 2 commits July 15, 2026 13:34
fixes the/path/to/datacontract/lint/resolve.py:72: SyntaxWarning: 'return' in a 'finally' block
@Cupprum Cupprum changed the title SyntaxError: Issue #1383 Fix SyntaxError during installation of datacontract-cli Jul 15, 2026
@Cupprum

Cupprum commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

This PR fixes the Issue #1383

@Cupprum

Cupprum commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

take a look pls @jschoedl

@jschoedl

Copy link
Copy Markdown
Collaborator

Thank you!

@jschoedl
jschoedl merged commit 832dd9f into datacontract:main Jul 21, 2026
13 checks passed
@jschoedl jschoedl linked an issue Jul 21, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Receiving SyntaxWarning when using the datacontract Python library

2 participants