Skip to content

Clarify ClientRequestArgs.timeout units#3149

Open
lunadogbot wants to merge 1 commit into
mainfrom
orch/issue-143
Open

Clarify ClientRequestArgs.timeout units#3149
lunadogbot wants to merge 1 commit into
mainfrom
orch/issue-143

Conversation

@lunadogbot
Copy link
Copy Markdown
Contributor

Summary

  • Adds a focused Node reference generation annotation for http.ClientRequestArgs.timeout.
  • Documents the timeout value as milliseconds on the generated property page.

Validation

  • cd reference_gen && deno task types:node && deno task doc:node
  • cd reference_gen && deno eval 'const files = JSON.parse(await Deno.readTextFile("gen/node.json")); const page = files["http/~/ClientRequestArgs.timeout.json"]; if (!page) throw new Error("missing page"); const text = JSON.stringify(page); if (!text.includes("Timeout in milliseconds.")) throw new Error("missing timeout docs"); console.log("verified ClientRequestArgs.timeout docs include milliseconds");'

Closes #3147

Closes bartlomieju/orchid-inbox#143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback: /api/node/http/~/ClientRequestArgs.timeout - Needs Improvement

1 participant