Clarify ClientRequestArgs.timeout units#3149
Open
lunadogbot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http.ClientRequestArgs.timeout.Validation
cd reference_gen && deno task types:node && deno task doc:nodecd reference_gen && deno eval 'const files = JSON.parse(await Deno.readTextFile("gen/node.json")); const page = files["http/~/ClientRequestArgs.timeout.json"]; if (!page) throw new Error("missing page"); const text = JSON.stringify(page); if (!text.includes("Timeout in milliseconds.")) throw new Error("missing timeout docs"); console.log("verified ClientRequestArgs.timeout docs include milliseconds");'Closes #3147
Closes bartlomieju/orchid-inbox#143