fix(query): avoid eager UID materialization on posting reads - #9809
Open
gooohgb wants to merge 8 commits into
Open
fix(query): avoid eager UID materialization on posting reads#9809gooohgb wants to merge 8 commits into
gooohgb wants to merge 8 commits into
Conversation
Contributor
Author
|
Hi, @matthewmcneely , could you please help review this PR? It’s affecting our production memory monitoring metrics and causing alerts. We’d really appreciate it if this could be reviewed and fixed as soon as possible. Thanks! |
matthewmcneely
requested changes
Aug 10, 2026
gooohgb
force-pushed
the
fix-calculated-uids-materialization
branch
from
August 11, 2026 05:17
ce28734 to
f647955
Compare
Contributor
Author
|
Hi @matthewmcneely , thank you for the review. I’ve updated the implementation based on your feedback. Could you please take another look when you have a chance? |
matthewmcneely
requested changes
Aug 11, 2026
Contributor
Author
|
Hi @matthewmcneely, thank you again for the detailed review. I have updated the implementation based on your feedback. While validating the changes, I also found and fixed a regression affecting negative pagination ( The CI checks are currently stuck. Could you please take another look at the updated implementation when you have a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related @matthewmcneely : #9807
This PR avoids eagerly materializing the full UID slice for posting lists on read paths where that work is not useful or actively bypasses existing optimizations.
Changes:
calculateUids()behind the posting-list cache being enabled, so--cache percentage=0,...does not build and immediately discard a full[]uint64.calculatedUidsfor boundedUids()reads withFirstorIntersect, preserving early-stop and compressed-intersection paths.Uids()allocation size for bounded and small-intersect reads.GetUids()in worker paths that do not consume a full UID list, including count, scalar comparison,has,uid_in, facets, pagination, and intersect paths.Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.