From 402b027ea8b99d8d03979764e274c0bd28961d0f Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 02:04:02 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../ukp/dkpro/lexsemresource/core/util/FileUtils.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/de.tudarmstadt.ukp.dkpro.lexsemresource.core-asl/src/main/java/de/tudarmstadt/ukp/dkpro/lexsemresource/core/util/FileUtils.java b/de.tudarmstadt.ukp.dkpro.lexsemresource.core-asl/src/main/java/de/tudarmstadt/ukp/dkpro/lexsemresource/core/util/FileUtils.java index 14d613c..8d9ac4e 100644 --- a/de.tudarmstadt.ukp.dkpro.lexsemresource.core-asl/src/main/java/de/tudarmstadt/ukp/dkpro/lexsemresource/core/util/FileUtils.java +++ b/de.tudarmstadt.ukp.dkpro.lexsemresource.core-asl/src/main/java/de/tudarmstadt/ukp/dkpro/lexsemresource/core/util/FileUtils.java @@ -23,6 +23,7 @@ import java.io.InputStream; import java.io.OutputStream; import java.net.URL; +import java.nio.file.Files; import java.util.HashMap; import java.util.Map; @@ -59,7 +60,7 @@ public static File getStreamAsFile(final InputStream is) { OutputStream os = null; try { - final File f = File.createTempFile("dkpro_stream", "tmp"); + final File f = Files.createTempFile("dkpro_stream", "tmp").toFile(); f.deleteOnExit(); os = new FileOutputStream(f); IOUtils.copy(is, os); @@ -111,7 +112,7 @@ public static synchronized File getUrlAsFile(URL aUrl, boolean aCache) // Get a temporary file which will be deleted when the JVM shuts // down. - file = File.createTempFile(name, suffix); + file = Files.createTempFile(name, suffix).toFile(); file.deleteOnExit(); // Now copy the file from the URL to the file. @@ -135,4 +136,4 @@ public static synchronized File getUrlAsFile(URL aUrl, boolean aCache) return file; } -} \ No newline at end of file +}