Commit d5bef4c
fix(wincred): Use UTF-16 encoding for passwords
This change adds UTF-16 encoding to the Windows credential helper.
As recommended by the author of the wincred library, the password
should be encoded to allow other applications to use the same password.
This is especially needed when the docker image repository is hosted on
a JFrog Artifactory, that also hosts Python repositories. Because nobody
wants to store their credentials in as plain test within the _pip.ini_,
they're going to enable the keyring support for pip, which in turn uses
the Win32API that assumes that the password is a UTF-16 encoded string.
Since this is not the case pip will crash with an encoding error.
Signed-off-by: Philipp Krüger <github.khab3@passinbox.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>1 parent ed71c9e commit d5bef4c
16 files changed
Lines changed: 4129 additions & 2 deletions
File tree
- vendor
- golang.org/x/text
- encoding
- internal
- identifier
- unicode
- internal/utf8internal
- runes
- transform
- wincred
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments