From d2246c2c9049833af27e314f7483c6f4ff09c140 Mon Sep 17 00:00:00 2001 From: Tom Naessens Date: Wed, 21 Oct 2026 17:42:59 +0200 Subject: [PATCH] Drop the expected failures from the Examples check TESTed now puts typed literal arguments of Haskell calls in parentheses (dodona-edu/universal-judge#732), so smallest/haskell, the only expected failure, passes. With the Examples check in place no new expected failures should arrive, so the mechanism goes: a reference solution that isn't judged correct fails the check. Co-Authored-By: Claude Opus 5.5 --- .github/check-examples.sh | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/.github/check-examples.sh b/.github/check-examples.sh index e9dbc59..3dcd9cb 100755 --- a/.github/check-examples.sh +++ b/.github/check-examples.sh @@ -6,15 +6,6 @@ JUDGE=${JUDGE:-/judge} -# Exercise/language pairs that must fail until fixed; they fail the check once they pass. -# smallest/haskell: TESTed generates `smallest 5 :: Int 6 :: Int`, https://github.com/dodona-edu/universal-judge/issues/568 -expected_failure() { - case $1 in - smallest/haskell) return 0 ;; - esac - return 1 -} - # Per exercise (a directory under tested/ with a config.json): \t\t. LIST=' import json, os, sys @@ -150,13 +141,8 @@ while IFS=$tab read -r exercise suite solution; do passed=false fi - if $passed && expected_failure "$exercise/$language"; then - echo "UNEXPECTED PASS $exercise ($language): remove \"$exercise/$language\" from expected_failure in .github/check-examples.sh" - exit_code=1 - elif $passed; then + if $passed; then echo "ok $exercise ($language)" - elif expected_failure "$exercise/$language"; then - echo "expected failure $exercise ($language)" else echo "FAIL $exercise ($language)" cat "$details"