Skip to content

Commit c55b84b

Browse files
committed
fix: accumulate all rows in CoreSwtbotTools.tableItems
The loop reassigned the list each iteration, so a table with N rows returned only the last row. Accumulate instead, matching the javadoc and the sibling treeItems helper. Empty tables now return an empty list rather than null.
1 parent 477d9ac commit c55b84b

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎com.avaloq.tools.ddk.test.ui/META-INF/MANIFEST.MF‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: com.avaloq.tools.ddk.test.ui
44
Bundle-SymbolicName: com.avaloq.tools.ddk.test.ui;singleton:=true
5-
Bundle-Version: 17.3.3.qualifier
5+
Bundle-Version: 17.3.4.qualifier
66
Bundle-Vendor: Avaloq Group AG
77
Bundle-RequiredExecutionEnvironment: JavaSE-21
88
Bundle-Activator: com.avaloq.tools.ddk.test.ui.Activator

‎com.avaloq.tools.ddk.test.ui/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<version>18.0.1-SNAPSHOT</version>
77
<relativePath>../ddk-parent</relativePath>
88
</parent>
9-
<version>17.3.3-SNAPSHOT</version>
9+
<version>17.3.4-SNAPSHOT</version>
1010

1111
<artifactId>com.avaloq.tools.ddk.test.ui</artifactId>
1212
<packaging>eclipse-plugin</packaging>

‎com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ public static List<SWTBotTableItem> tableItems(final SWTWorkbenchBot bot, final
346346
waitForTableItem(bot, table);
347347
List<SWTBotTableItem> items = new ArrayList<SWTBotTableItem>();
348348
for (int i = 0; i < table.rowCount(); i++) {
349-
items = new ArrayList<SWTBotTableItem>(Arrays.asList(table.getTableItem(i)));
349+
items.add(table.getTableItem(i));
350350
}
351351
return items;
352352
}

0 commit comments

Comments
 (0)