Skip to content

Port ProcessTreeView to GTK4#525

Open
stsdc wants to merge 48 commits into
mainfrom
stsdc/gtk4-treeview
Open

Port ProcessTreeView to GTK4#525
stsdc wants to merge 48 commits into
mainfrom
stsdc/gtk4-treeview

Conversation

@stsdc
Copy link
Copy Markdown
Member

@stsdc stsdc commented Feb 26, 2026

The intent is to future proof the process list and lay some ground for a tree view reintroduction.

@stsdc stsdc linked an issue Feb 26, 2026 that may be closed by this pull request
@stsdc stsdc requested a review from a team March 5, 2026 12:27
@stsdc stsdc marked this pull request as ready for review March 5, 2026 13:11
@stsdc stsdc added this to OS 9 Mar 5, 2026
@stsdc stsdc moved this to Needs Review in OS 9 Mar 5, 2026
Comment thread src/meson.build Outdated
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments about code style etc

Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
@danirabbit danirabbit requested a review from a team March 5, 2026 17:20
Comment thread src/Models/TreeViewModel.vala
Comment thread src/Models/TreeViewModel.vala Outdated
Comment thread src/Models/TreeViewModel.vala Outdated
@stsdc stsdc requested a review from danirabbit May 10, 2026 15:33
@stsdc
Copy link
Copy Markdown
Member Author

stsdc commented May 10, 2026

I have binded all the values from a ProcessRowData to the rows in the ColumnView. This fixed unnecessary list jumps on every update. Thanks to @alice-mkh and sadlyascii for the help!

@stsdc stsdc requested a review from a team May 10, 2026 16:14
Copy link
Copy Markdown
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just take a glance at the changes, but leaving some comments that I noticed or concerned.

Comment thread src/Models/ProcessRowData.vala
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala
Comment thread src/Models/TreeViewFilter.vala
Comment thread src/Models/TreeViewFilter.vala Outdated
Comment thread src/Models/TreeViewFilter.vala Outdated
Comment thread src/Views/ProcessView/ProcessTreeView/ProcessTreeView.vala Outdated
Comment thread src/Models/TreeViewModel.vala Outdated
Comment thread src/Models/TreeViewModel.vala Outdated
Comment thread src/Models/TreeViewModel.vala Outdated
Comment thread src/Models/TreeViewModel.vala Outdated
@stsdc
Copy link
Copy Markdown
Member Author

stsdc commented May 21, 2026

@ryonakano thank you for the review! It did help a lot to cleanup this PR. I think I have addressed all of them. Let me know if you have any more concerns 👍

@stsdc stsdc requested a review from ryonakano May 21, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

Rewrite process tree view

4 participants