From 979e86feaf38622b6b5929f5d1d1efddc7b9461f Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 15 Oct 2022 22:44:29 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- pytext/legacy/data/dataset.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/pytext/legacy/data/dataset.py b/pytext/legacy/data/dataset.py index 2b082f021..5d833ef9e 100644 --- a/pytext/legacy/data/dataset.py +++ b/pytext/legacy/data/dataset.py @@ -200,7 +200,26 @@ def download(cls, root, check=None): elif ext == ".tgz" or ext == ".gz" and ext_inner == ".tar": with tarfile.open(zpath, "r:gz") as tar: dirs = list(tar.getmembers()) - tar.extractall(path=path, members=dirs) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=path, members=dirs) elif ext == ".gz": with gzip.open(zpath, "rb") as gz: with open(zroot, "wb") as uncompressed: