Skip to content

fix(dash0): drag-to-zoom on the Timing chart - #617

Merged
fclairamb merged 1 commit into
mainfrom
fix/issue-14-timing-range-zoom
Oct 20, 2026
Merged

fclairamb merged 1 commit into
mainfrom
fix/issue-14-timing-range-zoom

Conversation

@fclairamb

Copy link
Copy Markdown
Owner

Report

From in-app report fclairamb/solidping-business#14 (v0.40.1, demo org):

Selecting a range on timing doesn't work like it works on for response time.

Diagnosis

The check page renders TimingChartCard for graphView=timing. TimingChart (web/dash0/src/components/checks/timing-chart.tsx) had no mouse/touch handlers and the route never passed it graphFrom/graphTo. So a drag did nothing, and a zoom already in the URL (the reporter's link had one) was ignored.

Fix

  • TimingChart gets the response time chart's gesture: a band while dragging, the window written to graphFrom/graphTo, the fetch narrowed to it (useChartWindowResults already took a zoom), a Reset zoom button and double-click reset.
  • The zoom is shared by both views through the URL, so switching views keeps it.
  • Changing the Timing range drops the zoom, as it does on the response time chart.

Test plan

  • New e2e test check-http-timing.spec.ts › "dragging a range on the Timing chart zooms like the response time chart". It fails on main (no graphFrom after the drag) and passes here.
  • check-http-timing.spec.ts and check-chart-zoom.spec.ts green against a side-car server.
  • tsc, eslint on the touched files, lint:e2e, typecheck:e2e.

Closes fclairamb/solidping-business#14

🤖 Generated with Claude Code

…clairamb/solidping-business#14)

Dragging a range on the check page's Timing view did nothing, while the same
gesture zooms the response time chart. TimingChart
(web/dash0/src/components/checks/timing-chart.tsx) had no drag handlers and
never received graphFrom/graphTo, so it also ignored a zoom already in the URL.
It now has the same gesture (band while dragging, URL-backed window, narrowed
fetch, Reset zoom button, double-click reset), and a range change drops the zoom.
The new e2e test in check-http-timing.spec.ts fails on the previous code (no
graphFrom in the URL after the drag) and passes now.

Closes fclairamb/solidping-business#14

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.36%. Comparing base (d4d9b21) to head (1768999).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   83.37%   83.36%   -0.02%     
==========================================
  Files        1238     1238              
  Lines      127064   127064              
==========================================
- Hits       105945   105931      -14     
- Misses      21110    21124      +14     
  Partials        9        9              

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fclairamb
fclairamb merged commit 931816c into main Oct 20, 2026
32 of 34 checks passed
@fclairamb
fclairamb deleted the fix/issue-14-timing-range-zoom branch October 20, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant