Repository navigation
fix(dash0): drag-to-zoom on the Timing chart - #617
Merged
Merged
Conversation
…clairamb/solidping-business#14) Dragging a range on the check page's Timing view did nothing, while the same gesture zooms the response time chart. TimingChart (web/dash0/src/components/checks/timing-chart.tsx) had no drag handlers and never received graphFrom/graphTo, so it also ignored a zoom already in the URL. It now has the same gesture (band while dragging, URL-backed window, narrowed fetch, Reset zoom button, double-click reset), and a range change drops the zoom. The new e2e test in check-http-timing.spec.ts fails on the previous code (no graphFrom in the URL after the drag) and passes now. Closes fclairamb/solidping-business#14 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 83.37% 83.36% -0.02%
==========================================
Files 1238 1238
Lines 127064 127064
==========================================
- Hits 105945 105931 -14
- Misses 21110 21124 +14
Partials 9 9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report
From in-app report fclairamb/solidping-business#14 (v0.40.1, demo org):
Diagnosis
The check page renders
TimingChartCardforgraphView=timing.TimingChart(web/dash0/src/components/checks/timing-chart.tsx) had no mouse/touch handlers and the route never passed itgraphFrom/graphTo. So a drag did nothing, and a zoom already in the URL (the reporter's link had one) was ignored.Fix
TimingChartgets the response time chart's gesture: a band while dragging, the window written tographFrom/graphTo, the fetch narrowed to it (useChartWindowResultsalready took azoom), a Reset zoom button and double-click reset.Test plan
check-http-timing.spec.ts› "dragging a range on the Timing chart zooms like the response time chart". It fails onmain(nographFromafter the drag) and passes here.check-http-timing.spec.tsandcheck-chart-zoom.spec.tsgreen against a side-car server.tsc, eslint on the touched files,lint:e2e,typecheck:e2e.Closes fclairamb/solidping-business#14
🤖 Generated with Claude Code