Java: Delete old deprecated code.

Author: aschackmull

java/ql/lib/semmle/code/java/Expr.qll

@@ -2732,11 +2732,6 @@ class PatternExpr extends Expr {
    */
   LocalVariableDeclExpr asBindingOrUnnamedPattern() { result = this }
 
-  /**
-   * DEPRECATED: alias for `asBindingOrUnnamedPattern`.
-   */
-  deprecated LocalVariableDeclExpr asBindingPattern() { result = this.asBindingOrUnnamedPattern() }
-
   /**
    * Gets this pattern cast to a record pattern.
    */

java/ql/lib/semmle/code/java/Member.qll

@@ -810,14 +810,6 @@ class Field extends Member, ExprParent, @field, Variable {
     )
   }
 
-  /**
-   * DEPRECATED: The result is always `this`.
-   */
-  deprecated Field getSourceDeclaration() { result = this }
-
-  /** DEPRECATED: This always holds. */
-  deprecated predicate isSourceDeclaration() { any() }
-
   override predicate isPublic() {
     Member.super.isPublic()
     or

java/ql/lib/semmle/code/java/Statement.qll

@@ -558,11 +558,6 @@ class ConstCase extends SwitchCase {
 class PatternCase extends SwitchCase {
   PatternCase() { exists(PatternExpr pe | pe.isNthChildOf(this, _)) }
 
-  /**
-   * DEPRECATED: alias for getPattern(0)
-   */
-  deprecated PatternExpr getPattern() { result = this.getPattern(0) }
-
   /**
    * Gets this case's `n`th pattern.
    */

java/ql/lib/semmle/code/java/Type.qll

@@ -637,9 +637,6 @@ class RefType extends Type, Annotatable, Modifiable, @reftype {
     this.(NestedType).getEnclosingType().getNestedName() + "$" + this.getName() = result
   }
 
-  /** DEPRECATED: Alias for `getNestedName`. */
-  deprecated string nestedName() { result = this.getNestedName() }
-
   /**
    * Gets the source declaration of this type.
    *

java/ql/lib/semmle/code/java/controlflow/Dominance.qll

@@ -10,57 +10,12 @@ import java
  * Predicates for basic-block-level dominance.
  */
 
-/**
- * DEPRECATED: Use `BasicBlock::immediatelyDominates` instead.
- *
- * The immediate dominance relation for basic blocks.
- */
-deprecated predicate bbIDominates(BasicBlock dom, BasicBlock node) {
-  dom.immediatelyDominates(node)
-}
-
 /** Exit points for basic-block control-flow. */
 private predicate bbSink(BasicBlock exit) { exit.getLastNode() instanceof ControlFlow::ExitNode }
 
 /** Reversed `bbSucc`. */
 private predicate bbPred(BasicBlock post, BasicBlock pre) { post = pre.getASuccessor() }
 
-/** The immediate post-dominance relation on basic blocks. */
-deprecated predicate bbIPostDominates(BasicBlock dominator, BasicBlock node) =
-  idominance(bbSink/1, bbPred/2)(_, dominator, node)
-
-/**
- * DEPRECATED: Use `BasicBlock::strictlyDominates` instead.
- *
- * Holds if `dom` strictly dominates `node`.
- */
-deprecated predicate bbStrictlyDominates(BasicBlock dom, BasicBlock node) {
-  dom.strictlyDominates(node)
-}
-
-/**
- * DEPRECATED: Use `BasicBlock::dominates` instead.
- *
- * Holds if `dom` dominates `node`. (This is reflexive.)
- */
-deprecated predicate bbDominates(BasicBlock dom, BasicBlock node) { dom.dominates(node) }
-
-/**
- * DEPRECATED: Use `BasicBlock::strictlyPostDominates` instead.
- *
- * Holds if `dom` strictly post-dominates `node`.
- */
-deprecated predicate bbStrictlyPostDominates(BasicBlock dom, BasicBlock node) {
-  dom.strictlyPostDominates(node)
-}
-
-/**
- * DEPRECATED: Use `BasicBlock::postDominates` instead.
- *
- * Holds if `dom` post-dominates `node`. (This is reflexive.)
- */
-deprecated predicate bbPostDominates(BasicBlock dom, BasicBlock node) { dom.postDominates(node) }
-
 /**
  * The dominance frontier relation for basic blocks.
  *

java/ql/lib/semmle/code/java/dataflow/FlowSources.qll

@@ -43,14 +43,6 @@ abstract class SourceNode extends DataFlow::Node {
   abstract string getThreatModel();
 }
 
-/**
- * DEPRECATED: Use `ActiveThreatModelSource` instead.
- *
- * A class of data flow sources that respects the
- * current threat model configuration.
- */
-deprecated class ThreatModelFlowSource = ActiveThreatModelSource;
-
 /**
  * A data flow source that is enabled in the current threat model configuration.
  */

java/ql/lib/semmle/code/java/dataflow/FlowSummary.qll

@@ -8,14 +8,6 @@ import java
 private import internal.FlowSummaryImpl as Impl
 private import internal.DataFlowUtil
 
-deprecated class SummaryComponent = Impl::Private::SummaryComponent;
-
-deprecated module SummaryComponent = Impl::Private::SummaryComponent;
-
-deprecated class SummaryComponentStack = Impl::Private::SummaryComponentStack;
-
-deprecated module SummaryComponentStack = Impl::Private::SummaryComponentStack;
-
 /** A synthetic callable with a set of concrete call sites and a flow summary. */
 abstract class SyntheticCallable extends string {
   bindingset[this]
@@ -147,5 +139,3 @@ private class SummarizedSyntheticCallableAdapter extends SummarizedCallable::Ran
     )
   }
 }
-
-deprecated class RequiredSummaryComponentStack = Impl::Private::RequiredSummaryComponentStack;

java/ql/lib/semmle/code/java/dataflow/NullGuards.qll

@@ -196,18 +196,6 @@ Expr basicNullGuard(Expr e, boolean branch, boolean isnull) {
   Guards_v3::nullGuard(result, any(GuardValue v | v.asBooleanValue() = branch), e, isnull)
 }
 
-/**
- * DEPRECATED: Use `basicNullGuard` instead.
- *
- * Gets an expression that directly tests whether a given expression, `e`, is null or not.
- *
- * If `result` evaluates to `branch`, then `e` is guaranteed to be null if `isnull`
- * is true, and non-null if `isnull` is false.
- */
-deprecated Expr basicOrCustomNullGuard(Expr e, boolean branch, boolean isnull) {
-  result = basicNullGuard(e, branch, isnull)
-}
-
 /**
  * Gets an expression that directly tests whether a given SSA variable is null or not.
  *
@@ -218,18 +206,6 @@ Expr directNullGuard(SsaDefinition v, boolean branch, boolean isnull) {
   result = basicNullGuard(sameValue(v, _), branch, isnull)
 }
 
-/**
- * DEPRECATED: Use `nullGuardControls`/`nullGuardControlsBranchEdge` instead.
- *
- * Gets a `Guard` that tests (possibly indirectly) whether a given SSA variable is null or not.
- *
- * If `result` evaluates to `branch`, then `v` is guaranteed to be null if `isnull`
- * is true, and non-null if `isnull` is false.
- */
-deprecated Guard nullGuard(SsaDefinition v, boolean branch, boolean isnull) {
-  result = directNullGuard(v, branch, isnull)
-}
-
 /**
  * Holds if there exists a null check on `v`, such that taking the branch edge
  * from `bb1` to `bb2` implies that `v` is guaranteed to be null if `isnull` is

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowNodes.qll

@@ -198,19 +198,6 @@ module Public {
       or
       result = this.getType() and not exists(this.getImprovedTypeBound())
     }
-
-    /**
-     * Holds if this element is at the specified location.
-     * The location spans column `startcolumn` of line `startline` to
-     * column `endcolumn` of line `endline` in file `filepath`.
-     * For more information, see
-     * [Locations](https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/).
-     */
-    deprecated predicate hasLocationInfo(
-      string filepath, int startline, int startcolumn, int endline, int endcolumn
-    ) {
-      this.getLocation().hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
-    }
   }
 
   /**

java/ql/lib/semmle/code/java/frameworks/Jndi.qll

@@ -48,18 +48,6 @@ class MethodLdapNameAddAll extends Method {
   }
 }
 
-/**
- * DEPRECATED: No longer needed as clone steps are handled uniformly.
- *
- * A method with the name `clone` declared in `javax.naming.ldap.LdapName`.
- */
-deprecated class MethodLdapNameClone extends Method {
-  MethodLdapNameClone() {
-    this.getDeclaringType() instanceof TypeLdapName and
-    this.hasName("clone")
-  }
-}
-
 /** A method with the name `getAll` declared in `javax.naming.ldap.LdapName`. */
 class MethodLdapNameGetAll extends Method {
   MethodLdapNameGetAll() {