-
Notifications
You must be signed in to change notification settings - Fork 268
Add Java Platform Module System (JPMS) support #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cowwoc
wants to merge
23
commits into
google:master
Choose a base branch
from
cowwoc:add-module-info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c04ad9e
Add Java Platform Module System (JPMS) support
cowwoc ad1f8d1
Fix JPMS split package violations and enable documentation generation
cowwoc 2659b4f
Update copyright year to 2025 for newly created file
cowwoc b78c9a0
Make module-info compilation CI-safe
cowwoc 8aead27
Restore package documentation for proto extensions
cowwoc 5760bfd
Update core/src/main/java/module-info.java
cowwoc 6585167
Fix module-info setup and GWT compatibility issues
cpovirk 7db6fde
Merge remote-tracking branch 'origin/master' into add-module-info
cpovirk 28162cb
Remove unnecessary java.compiler requirement from module-info.java
cpovirk 461d266
test under 25 instead of 11, use 999.0.0-SNAPSHOT throughout instead …
cpovirk 4121459
Restore Employee sample extension and fix modular test visibility
cpovirk 575a6ac
document add-exports
cpovirk 3c8e545
remove autovalue annotations from module
cpovirk 4136d0f
Move modular build configuration and GWT exclusions to core/pom.xml
cpovirk 80455f7
restore comment about why add-exports
cpovirk c9496fc
add transitive for junit, where it is probably important for users of…
cpovirk caacd60
transitive for guava, too
cpovirk 4319994
use java 26 for builds
cpovirk eb00006
pin artifacts
cpovirk 1b70d3a
Fix CI failure by moving modular compilation to a JDK 9+ profile
cpovirk fd02f03
Skip main compilation in CI test job to preserve build artifacts
cpovirk bd6d3a1
Unpack build artifacts in CI test job to satisfy test-compilation
cpovirk 0b7ad32
Merge branch 'master' into add-module-info
cpovirk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright (c) 2025 Google, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| module com.google.truth { | ||
| requires transitive com.google.common; | ||
|
|
||
| /* | ||
| * AutoValue's annotations aren't ready for the module system: | ||
| * https://github.com/google/auto/issues/597. Let's hope that our usages are internal enough that | ||
| * we don't need to worry about listing them here. | ||
| */ | ||
|
|
||
| requires static transitive com.google.errorprone.annotations; | ||
| requires static transitive com.google.j2objc.annotations; | ||
| requires static transitive junit; | ||
| requires static transitive org.jspecify; | ||
| requires static transitive org.objectweb.asm; | ||
|
|
||
| exports com.google.common.truth; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error #1 from
mvn clean install:That's kind of just a weird case: We probably "should" have a separate
pom.xmland a separate module for the example extension. Then it could export thisextensionpackage.I am 100% on board with just removing the sample extension from the testing: It's just a sample, and we'll continue to build and test it internally, so it will remain up to date.