Skip to content

feat(bigquery-jdbc): implement JDBC getObject type coercion support #13257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Neenu1995 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(bigquery-jdbc): implement JDBC getObject type coercion support #13257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
690c860
feat(bigquery-jdbc): implement JDBC getObject type coercion support
Neenu1995 May 22, 2026
15948cf
address comments
Neenu1995 May 22, 2026
8529c9b
add parameterized tests
Neenu1995 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryBaseResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,25 @@ public boolean isClosed() {

public abstract Object getObject(int columnIndex) throws SQLException;

@Override
public <T> T getObject(int columnIndex, Class<T> type) throws SQLException {
LOG.finestTrace("getObject");
try {
Object value = getObject(columnIndex);
if (value == null) {
return null;
}
return this.bigQueryTypeCoercer.coerceTo(type, value, this.LOG);
} catch (BigQueryJdbcCoercionNotFoundException e) {
throw createCoercionException(columnIndex, type, e);
}
Comment thread
Neenu1995 marked this conversation as resolved.
Outdated
}

@Override
public <T> T getObject(String columnLabel, Class<T> type) throws SQLException {
return getObject(getColumnIndex(columnLabel), type);
}

protected int getColumnIndex(String columnLabel) throws SQLException {
LOG.finestTrace("getColumnIndex");
checkClosed();
Expand Down
10 changes: 0 additions & 10 deletions java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryNoOpsResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,16 +655,6 @@ public void updateNClob(String columnLabel, Reader reader) throws SQLException {
throw new BigQueryJdbcSqlFeatureNotSupportedException(METHOD_NOT_IMPLEMENTED);
}

@Override
public <T> T getObject(int columnIndex, Class<T> type) throws SQLException {
throw new BigQueryJdbcSqlFeatureNotSupportedException(METHOD_NOT_IMPLEMENTED);
}

@Override
public <T> T getObject(String columnLabel, Class<T> type) throws SQLException {
throw new BigQueryJdbcSqlFeatureNotSupportedException(METHOD_NOT_IMPLEMENTED);
}

@Override
public <T> T unwrap(Class<T> iface) throws SQLException {
throw new BigQueryJdbcSqlFeatureNotSupportedException(METHOD_NOT_IMPLEMENTED);
Expand Down
41 changes: 41 additions & 0 deletions ...gquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryTypeCoercionUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,12 @@
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.time.OffsetDateTime;
Comment thread
Neenu1995 marked this conversation as resolved.
import java.time.Period;
import java.time.ZoneOffset;
import java.time.format.DateTimeFormatter;
import java.time.temporal.ChronoUnit;
import java.util.TimeZone;
import java.util.concurrent.TimeUnit;
import org.apache.arrow.vector.PeriodDuration;
import org.apache.arrow.vector.util.Text;
Expand Down Expand Up @@ -86,6 +89,37 @@ class BigQueryTypeCoercionUtility {
Timestamp.class)
.registerTypeCoercion(
(Date date) -> new Timestamp(date.getTime()), Date.class, Timestamp.class)
.registerTypeCoercion(
(LocalDateTime ldt) -> Date.valueOf(ldt.toLocalDate()),
LocalDateTime.class,
Date.class)
.registerTypeCoercion(
(LocalDateTime ldt) -> {
long millisOfDay =
java.util.concurrent.TimeUnit.NANOSECONDS.toMillis(
ldt.toLocalTime().toNanoOfDay());
long localMillis = TimeZoneCache.getLocalMillis(millisOfDay);
return new Time(localMillis);
},
LocalDateTime.class,
Time.class)
.registerTypeCoercion((Date date) -> date.toLocalDate(), Date.class, LocalDate.class)
.registerTypeCoercion(
(Time time) -> {
long millis = time.getTime();
long localMillis = millis + TimeZone.getDefault().getOffset(millis);
return LocalTime.ofNanoOfDay(
java.util.concurrent.TimeUnit.MILLISECONDS.toNanos(localMillis));
},
Time.class,
LocalTime.class)
Comment thread
Neenu1995 marked this conversation as resolved.
.registerTypeCoercion(
(Timestamp ts) -> ts.toLocalDateTime(), Timestamp.class, LocalDateTime.class)
Comment thread
Neenu1995 marked this conversation as resolved.
Outdated
.registerTypeCoercion(
(Timestamp ts) -> ts.toInstant().atOffset(ZoneOffset.UTC),
Timestamp.class,
OffsetDateTime.class)
.registerTypeCoercion((Timestamp ts) -> ts.toInstant(), Timestamp.class, Instant.class)
.registerTypeCoercion(new TimestampToString())
.registerTypeCoercion(new TimeToString())
.registerTypeCoercion((Long l) -> l != 0L, Long.class, Boolean.class)
Expand All @@ -106,6 +140,13 @@ class BigQueryTypeCoercionUtility {
(Boolean b) -> b ? BigDecimal.ONE : BigDecimal.ZERO,
Boolean.class,
BigDecimal.class)
.registerTypeCoercion(
(Integer i) -> BigDecimal.valueOf(i), Integer.class, BigDecimal.class)
.registerTypeCoercion((Long l) -> BigDecimal.valueOf(l), Long.class, BigDecimal.class)
.registerTypeCoercion(
(Double d) -> BigDecimal.valueOf(d), Double.class, BigDecimal.class)
.registerTypeCoercion((Float f) -> BigDecimal.valueOf(f), Float.class, BigDecimal.class)
.registerTypeCoercion((String s) -> new BigDecimal(s), String.class, BigDecimal.class)
.registerTypeCoercion(new PeriodDurationToString())
.registerTypeCoercion(unused -> (byte) 0, Void.class, Byte.class)
.registerTypeCoercion(unused -> 0, Void.class, Integer.class)
Expand Down
52 changes: 52 additions & 0 deletions ...igquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryArrowResultSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static com.google.common.truth.Truth.assertThat;
import static org.apache.arrow.vector.types.Types.MinorType.INT;
import static org.apache.arrow.vector.types.Types.MinorType.VARCHAR;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.mock;

import com.google.cloud.bigquery.Field;
Expand All @@ -32,10 +33,14 @@
import com.google.cloud.bigquery.storage.v1.ArrowSchema;
import com.google.common.collect.ImmutableList;
import java.io.IOException;
import java.math.BigDecimal;
import java.sql.Array;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Struct;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.BlockingQueue;
Expand Down Expand Up @@ -346,6 +351,53 @@ public void testIterationNested() throws SQLException {
assertThat(bigQueryArrowResultSetNested.isAfterLast()).isTrue();
}

@Test
public void testGetObjectWithType() throws SQLException {
assertThat(bigQueryArrowResultSet.next()).isTrue();

// java.time types
assertThat(bigQueryArrowResultSet.getObject("dateField", LocalDate.class))
.isEqualTo(LocalDate.of(1970, 1, 1));
assertThat(bigQueryArrowResultSet.getObject(11, LocalDate.class))
.isEqualTo(LocalDate.of(1970, 1, 1));

assertThat(bigQueryArrowResultSet.getObject("timeField", LocalTime.class))
.isEqualTo(LocalTime.of(0, 0, 1, 234_000_000));
assertThat(bigQueryArrowResultSet.getObject(10, LocalTime.class))
.isEqualTo(LocalTime.of(0, 0, 1, 234_000_000));

assertThat(bigQueryArrowResultSet.getObject("timeStampField", LocalDateTime.class))
.isEqualTo(LocalDateTime.of(1970, 1, 1, 0, 0, 0, 10_000_000));
assertThat(bigQueryArrowResultSet.getObject(5, LocalDateTime.class))
.isEqualTo(LocalDateTime.of(1970, 1, 1, 0, 0, 0, 10_000_000));

// Boolean
assertThat(bigQueryArrowResultSet.getObject("boolField", Boolean.class)).isFalse();
assertThat(bigQueryArrowResultSet.getObject(1, Boolean.class)).isFalse();

// Numbers & Coercions
assertThat(bigQueryArrowResultSet.getObject("int64Filed", Long.class)).isEqualTo(1L);
assertThat(bigQueryArrowResultSet.getObject(2, Integer.class)).isEqualTo(1);
assertThat(bigQueryArrowResultSet.getObject(2, String.class)).isEqualTo("1");

assertThat(bigQueryArrowResultSet.getObject("float64Field", Double.class))
.isEqualTo(Double.valueOf(1.1f));
Comment thread
Neenu1995 marked this conversation as resolved.
Outdated

// String
assertThat(bigQueryArrowResultSet.getObject("stringField", String.class)).isEqualTo("text1");

// BigDecimal / Numeric
assertThat(bigQueryArrowResultSet.getObject("numericField", BigDecimal.class))
.isEqualTo(BigDecimal.ONE);
assertThat(bigQueryArrowResultSet.getObject(9, Long.class)).isEqualTo(1L);

// Unsupported coercions should fail
assertThrows(
SQLException.class, () -> bigQueryArrowResultSet.getObject("boolField", LocalDate.class));
assertThrows(
SQLException.class, () -> bigQueryArrowResultSet.getObject("dateField", Boolean.class));
}

private int resultSetRowCount(BigQueryArrowResultSet resultSet) throws SQLException {
int rowCount = 0;
while (resultSet.next()) {
Expand Down
54 changes: 54 additions & 0 deletions ...bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryJsonResultSetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import static com.google.common.truth.Truth.assertThat;
import static java.time.Month.MARCH;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.mock;

import com.google.cloud.bigquery.Field;
Expand Down Expand Up @@ -47,6 +48,7 @@
import java.sql.Struct;
import java.sql.Time;
import java.sql.Timestamp;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.util.Calendar;
Expand Down Expand Up @@ -466,6 +468,58 @@ public void testDate() throws SQLException {
.isEqualTo(bigQueryJsonResultSet.getDate("fourteenth", calendar).getTime());
}

@Test
public void testGetObjectWithType() throws SQLException {
assertThat(resetResultSet()).isTrue();

// java.time types
assertThat(bigQueryJsonResultSet.getObject("fourteenth", LocalDate.class))
.isEqualTo(LocalDate.of(2020, 1, 15));
assertThat(bigQueryJsonResultSet.getObject(14, LocalDate.class))
.isEqualTo(LocalDate.of(2020, 1, 15));

assertThat(bigQueryJsonResultSet.getObject("twelfth", LocalTime.class))
.isEqualTo(LocalTime.of(11, 14, 19, 820000000));
assertThat(bigQueryJsonResultSet.getObject(12, LocalTime.class))
.isEqualTo(LocalTime.of(11, 14, 19, 820000000));

assertThat(bigQueryJsonResultSet.getObject("fifth", LocalDateTime.class))
.isEqualTo(LocalDateTime.of(2023, 3, 30, 11, 14, 19, 820000000));
assertThat(bigQueryJsonResultSet.getObject(5, LocalDateTime.class))
.isEqualTo(LocalDateTime.of(2023, 3, 30, 11, 14, 19, 820000000));

// Boolean
assertThat(bigQueryJsonResultSet.getObject("first", Boolean.class)).isFalse();
assertThat(bigQueryJsonResultSet.getObject(1, Boolean.class)).isFalse();

// Numbers & Coercions
assertThat(bigQueryJsonResultSet.getObject("second", Long.class)).isEqualTo(1L);
assertThat(bigQueryJsonResultSet.getObject(2, Integer.class)).isEqualTo(1);
assertThat(bigQueryJsonResultSet.getObject(2, Short.class)).isEqualTo((short) 1);
assertThat(bigQueryJsonResultSet.getObject(2, String.class)).isEqualTo("1");

assertThat(bigQueryJsonResultSet.getObject("third", Double.class)).isEqualTo(1.5D);
assertThat(bigQueryJsonResultSet.getObject(3, Float.class)).isEqualTo(1.5F);

// String
assertThat(bigQueryJsonResultSet.getObject("fourth", String.class)).isEqualTo(STRING_VAL);

// BigDecimal / Numeric
assertThat(bigQueryJsonResultSet.getObject("tenth", BigDecimal.class))
.isEqualTo(new BigDecimal("12345678"));
assertThat(bigQueryJsonResultSet.getObject(10, Long.class)).isEqualTo(12345678L);

assertThat(bigQueryJsonResultSet.getObject("eleventh", BigDecimal.class))
.isEqualTo(new BigDecimal("12345678.99"));
assertThat(bigQueryJsonResultSet.getObject(11, Double.class)).isEqualTo(12345678.99D);

// Unsupported coercions should fail
assertThrows(
SQLException.class, () -> bigQueryJsonResultSet.getObject("first", LocalDate.class));
assertThrows(
SQLException.class, () -> bigQueryJsonResultSet.getObject("fourteenth", Boolean.class));
}

private int resultSetRowCount(BigQueryJsonResultSet resultSet) throws SQLException {
int rowCount = 0;
while (resultSet.next()) {
Expand Down
Loading