eslintrc: enable few rules with minimal code changes (#3774)

Author: IvanGoncharov

.eslintrc.yml

@@ -227,7 +227,7 @@ rules:
   no-template-curly-in-string: error
   no-this-before-super: error
   no-undef: error
-  no-unexpected-multiline: off
+  no-unexpected-multiline: error
   no-unmodified-loop-condition: error
   no-unreachable: error
   no-unreachable-loop: error
@@ -253,7 +253,7 @@ rules:
   class-methods-use-this: off
   complexity: off
   consistent-return: off
-  consistent-this: off
+  consistent-this: error
   curly: error
   default-case: off
   default-case-last: error
@@ -369,7 +369,7 @@ rules:
   prefer-const: error
   prefer-destructuring: off
   prefer-exponentiation-operator: error
-  prefer-named-capture-group: off # ES2018
+  prefer-named-capture-group: off # needs a better support in TS, see https://github.com/microsoft/TypeScript/issues/32098
   prefer-numeric-literals: error
   prefer-object-has-own: off # TODO requires Node.js v16.9.0
   prefer-object-spread: error
@@ -378,7 +378,7 @@ rules:
   prefer-rest-params: off # TODO
   prefer-spread: error
   prefer-template: off
-  quote-props: off # Superseded by prettier
+  quote-props: [error, as-needed]
   radix: error
   require-await: error
   require-unicode-regexp: off

integrationTests/node/test.js

@@ -7,7 +7,7 @@ const graphqlPackageJSON = JSON.parse(
 
 const nodeVersions = graphqlPackageJSON.engines.node
   .split(' || ')
-  .map((version) => version.replace(/^(\^|>=)/, ''))
+  .map((version) => version.replace('^', '').replace('>=', ''))
   .sort((a, b) => b.localeCompare(a));
 
 for (const version of nodeVersions) {

resources/benchmark.ts

@@ -132,11 +132,11 @@ function collectSamples(modulePath: string) {
 // See http://www.itl.nist.gov/div898/handbook/eda/section3/eda3672.htm.
 // prettier-ignore
 const tTable: { [v: number]: number } = {
-  '1':  12.706, '2':  4.303, '3':  3.182, '4':  2.776, '5':  2.571, '6':  2.447,
-  '7':  2.365,  '8':  2.306, '9':  2.262, '10': 2.228, '11': 2.201, '12': 2.179,
-  '13': 2.16,   '14': 2.145, '15': 2.131, '16': 2.12,  '17': 2.11,  '18': 2.101,
-  '19': 2.093,  '20': 2.086, '21': 2.08,  '22': 2.074, '23': 2.069, '24': 2.064,
-  '25': 2.06,   '26': 2.056, '27': 2.052, '28': 2.048, '29': 2.045, '30': 2.042,
+  1:  12.706, 2:  4.303, 3:  3.182, 4:  2.776, 5:  2.571, 6:  2.447,
+  7:  2.365,  8:  2.306, 9:  2.262, 10: 2.228, 11: 2.201, 12: 2.179,
+  13: 2.16,   14: 2.145, 15: 2.131, 16: 2.12,  17: 2.11,  18: 2.101,
+  19: 2.093,  20: 2.086, 21: 2.08,  22: 2.074, 23: 2.069, 24: 2.064,
+  25: 2.06,   26: 2.056, 27: 2.052, 28: 2.048, 29: 2.045, 30: 2.042,
 };
 const tTableInfinity = 1.96;