Commit bbddc0c
committed
test: cover executeIgnoringIncremental traced path and drop unused traceSync
The traced branch of `executeIgnoringIncremental` was not exercised by
any subscriber-attached test, tripping the 100% coverage threshold on
CI. Add a case in execute-diagnostics-test that subscribes to
`graphql:execute` and asserts start/end around a call.
Also drop the `traceSync` helper from diagnostics.ts; every call site
invokes `channel.traceSync(...)` directly, so the export was dead code.
Mark the `require('node:diagnostics_channel')` CJS fallback and the
enclosing `catch` block with c8 ignore comments — they are only
reachable on Node 20.0-20.15 (pre-`getBuiltinModule`) and on runtimes
without `diagnostics_channel` at all, neither of which the unit tests
run on.1 parent 03c9fea commit bbddc0c
2 files changed
Lines changed: 14 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
93 | 94 | | |
| 95 | + | |
94 | 96 | | |
95 | 97 | | |
96 | 98 | | |
| |||
122 | 124 | | |
123 | 125 | | |
124 | 126 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | 127 | | |
141 | 128 | | |
142 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
81 | 93 | | |
82 | 94 | | |
83 | 95 | | |
| |||
0 commit comments