rename from isTrivialResolver => isDefaultResolver

Author: yaacovCR

integrationTests/diagnostics/test.js

@@ -205,7 +205,7 @@ function runResolveCase() {
         parentType: msg.parentType,
         fieldType: msg.fieldType,
         fieldPath: msg.fieldPath,
-        isTrivialResolver: msg.isTrivialResolver,
+        isDefaultResolver: msg.isDefaultResolver,
       }),
     end: () => events.push({ kind: 'end' }),
     asyncStart: () => events.push({ kind: 'asyncStart' }),
@@ -228,7 +228,7 @@ function runResolveCase() {
     assert.equal(hello.parentType, 'Query');
     assert.equal(hello.fieldType, 'String');
     // buildSchema never attaches field.resolve; all fields report as trivial.
-    assert.equal(hello.isTrivialResolver, true);
+    assert.equal(hello.isDefaultResolver, true);
   } finally {
     channel.unsubscribe(handler);
   }

src/execution/Executor.ts

@@ -1429,15 +1429,15 @@ function toNodes(fieldDetailsList: FieldDetailsList): ReadonlyArray<FieldNode> {
 function buildResolveCtx(
   info: GraphQLResolveInfo,
   args: { readonly [argument: string]: unknown },
-  isTrivialResolver: boolean,
+  isDefaultResolver: boolean,
 ): object {
   let cachedFieldPath: string | undefined;
   return {
     fieldName: info.fieldName,
     parentType: info.parentType.name,
     fieldType: String(info.returnType),
     args,
-    isTrivialResolver,
+    isDefaultResolver,
     get fieldPath() {
       cachedFieldPath ??= pathToArray(info.path).join('.');
       return cachedFieldPath;
@@ -1457,11 +1457,11 @@ function invokeResolverWithTracing(
   args: { readonly [argument: string]: unknown },
   contextValue: unknown,
   info: GraphQLResolveInfo,
-  isTrivialResolver: boolean,
+  isDefaultResolver: boolean,
 ): PromiseOrValue<unknown> {
   return traceMixed(
     tracingChannel,
-    buildResolveCtx(info, args, isTrivialResolver),
+    buildResolveCtx(info, args, isDefaultResolver),
     () => resolveFn(source, args, contextValue, info),
   );
 }

src/execution/__tests__/resolve-diagnostics-test.ts

@@ -116,7 +116,7 @@ describe('resolve diagnostics channel', () => {
     );
   });
 
-  it('reports isTrivialResolver based on field.resolve presence', () => {
+  it('reports isDefaultResolver based on field.resolve presence', () => {
     const trivialSchema = new GraphQLSchema({
       query: new GraphQLObjectType({
         name: 'Query',
@@ -141,7 +141,7 @@ describe('resolve diagnostics channel', () => {
 
     const starts = active.events.filter((e) => e.kind === 'start');
     const byField = new Map(
-      starts.map((e) => [e.ctx.fieldName, e.ctx.isTrivialResolver]),
+      starts.map((e) => [e.ctx.fieldName, e.ctx.isDefaultResolver]),
     );
     expect(byField.get('trivial')).to.equal(true);
     expect(byField.get('custom')).to.equal(false);