Skip to content

BE-525: HashQL: Remove implicit type-widening from Integer operations, and make comparison size aware #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 3 commits into
base: bm/be-515-hashql-remove-offset-0-materialization-fence-from-generated
Choose a base branch
from

fix: inst simplification size aware equality

f13bd33
Select commit
Loading
Failed to load commit list.
Open

BE-525: HashQL: Remove implicit type-widening from Integer operations, and make comparison size aware #8693

fix: inst simplification size aware equality
f13bd33
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2026 in 0s

63.38% (+0.40%) compared to 409cce2

View this Pull Request on Codecov

63.38% (+0.40%) compared to 409cce2

Details

Codecov Report

❌ Patch coverage is 97.42268% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.38%. Comparing base (409cce2) to head (f13bd33).

Files with missing lines Patch % Lines
libs/@local/hashql/mir/src/interpret/value/mod.rs 83.33% 1 Missing and 2 partials ⚠️
libs/@local/hashql/mir/src/interpret/error.rs 90.90% 1 Missing ⚠️
...hashql/mir/src/pass/transform/inst_simplify/mod.rs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                                            Coverage Diff                                            @@
##           bm/be-515-hashql-remove-offset-0-materialization-fence-from-generated    #8693      +/-   ##
=========================================================================================================
+ Coverage                                                                  62.98%   63.38%   +0.40%     
=========================================================================================================
  Files                                                                       1382     1384       +2     
  Lines                                                                     143255   144970    +1715     
  Branches                                                                    5893     5933      +40     
=========================================================================================================
+ Hits                                                                       90229    91890    +1661     
- Misses                                                                     52071    52121      +50     
- Partials                                                                     955      959       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov