Repository navigation
Preserve copy-mode search text after Esc so n/N can repeat it #5772
sinharaksh1t
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
In Herdr TUI 0.9.5 on macOS, pressing Esc after a copy-mode search clears the saved query and direction, so n/N can no longer repeat that search.
Reproduction:
Requested behavior: Esc should clear visible search highlights/selection while retaining the last search text and direction for n/N. A subsequent Esc, once highlights/selection are cleared, should still exit copy mode. This request concerns retaining the query within the current copy-mode session.
The v0.9.5 Esc handler explicitly clears search_query and search_direction: https://github.com/herdrdev/herdr/blob/v0.9.5/src/client/shell/copy_mode.rs#L112-L135
Could the remembered query/direction be kept separately from the visible highlight state, so clearing highlights does not disable repeat search?
All reactions