Skip to content

Commit bf83b4e

Browse files
committed
WIP: dra: remove inter-driver compatibility attributes
now that we can group by kube's standard pcieRoot attribute, we become compatible out of the box with other compliant DRA drivers, so we don't need to add extra compatibility attributes. We can reintroduce some driver-to-driver compatibility for special cases in the future WIP: needs docs updates Signed-off-by: Francesco Romani <fromani@redhat.com>
1 parent 3b213b1 commit bf83b4e

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

pkg/driver/dra_hooks.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@ func (cp *CPUDriver) createGroupedCPUDeviceSlices() [][]resourceapi.Device {
120120
"dra.cpu/socketID": {IntValue: &socketID},
121121
"dra.cpu/numCPUs": {IntValue: &availableCPUsInNUMANode},
122122
"dra.cpu/smtEnabled": {BoolValue: &smtEnabled},
123-
// TODO(pravk03): Remove. Hack to align with NIC (DRANet). We need some standard attribute to align other resources with CPU.
124-
"dra.net/numaNode": {IntValue: &numaID},
125123
},
126124
Capacity: deviceCapacity,
127125
AllowMultipleAllocations: ptr.To(true),
@@ -234,8 +232,6 @@ func (cp *CPUDriver) createCPUDeviceSlices() [][]resourceapi.Device {
234232
"dra.cpu/socketID": {IntValue: &socketID},
235233
"dra.cpu/coreID": {IntValue: &coreID},
236234
"dra.cpu/cpuID": {IntValue: &cpuID},
237-
// TODO(pravk03): Remove. Hack to align with NIC (DRANet). We need some standard attribute to align other resources with CPU.
238-
"dra.net/numaNode": {IntValue: &numaNode},
239235
},
240236
Capacity: make(map[resourceapi.QualifiedName]resourceapi.DeviceCapacity),
241237
}

0 commit comments

Comments
 (0)