Changes to simply addition of "built in" LUA scripts #1171
BuzzBurrowes
started this conversation in
Ideas
Replies: 1 comment
|
Hmmm yeah, the order changing with new scripts added isn't that big of a deal. I'd allow it :) |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I have a local change that makes it much easier to include new LUA scripts in the build (the scripts in 'element/scripts' that get compiled into the binary executable. It basically enumerates these at runtime instead of relying on hard coded changes to ScriptNode::getNumPrograms() etc.
But before I issue a pull request I need to find out if I am breaking anything functionality-wise...
My change results in a situation where the LUA scripts will not maintain the "program number" when new scripts are added and the executable is compiled. So you won't necessarily get the same program name back when you call ScriptNode::getProgramName() for a specific index number.
I think this is OK, since script nodes save out their full script when the session saves, not relying on "recalling" a script from a saved program number or the like.
But maybe I am not considering all use cases. Anyone have any thoughts?
All reactions