Skip to content

Enforce that node_ids are sorted in channel_announcements #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBlueMatt wants to merge 1 commit into
base: main
Choose a base branch
from

Enforce that node_ids are sorted in channel_announcements

ac7e4e8
Select commit
Loading
Failed to load commit list.
Open

Enforce that node_ids are sorted in channel_announcements #4611

Enforce that node_ids are sorted in channel_announcements
ac7e4e8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 1s

86.66% (+0.54%) compared to 44828f7

View this Pull Request on Codecov

86.66% (+0.54%) compared to 44828f7

Details

Codecov Report

❌ Patch coverage is 89.55224% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.66%. Comparing base (44828f7) to head (ac7e4e8).
⚠️ Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/routing/gossip.rs 76.19% 3 Missing and 2 partials ⚠️
lightning/src/routing/scoring.rs 95.45% 1 Missing ⚠️
lightning/src/routing/test_utils.rs 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4611      +/-   ##
==========================================
+ Coverage   86.12%   86.66%   +0.54%     
==========================================
  Files         157      159       +2     
  Lines      108922   110612    +1690     
  Branches   108922   110612    +1690     
==========================================
+ Hits        93812    95865    +2053     
+ Misses      12495    12221     -274     
+ Partials     2615     2526      -89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov