Check for individual fail.

Author: kiarn

usr/lib/python3/dist-packages/linuxmusterCli/pytests/test_typers_student.py

@@ -76,20 +76,27 @@ def test_add_and_remove_parents_both_shown_and_force_parents_listing(self, runne
         # get_parents was never explicitly requested but is implied by add/remove:
         assert 'No parent found!' in result.output
 
-    def test_add_parent_failure_aborts_the_rest_of_the_loop(self, runner, monkeypatch):
-        # BUG-like current behavior (documented, not fixed): the try/except in
-        # student.py wraps the WHOLE for-loop, not each iteration. So a single
-        # failing add_parent() call aborts processing of any parents after it
-        # in the same --add-parents list.
+    def test_add_parent_failure_does_not_abort_the_rest_of_the_loop(self, runner, monkeypatch):
+        # Each parent is now tried independently: a failing add_parent() call
+        # is reported but does not stop the remaining parents in the same
+        # --add-parents list from being processed.
         monkeypatch.setattr(student, 'LMNStudent', FakeStudent)
 
         result = runner.invoke(student.app, ['--add-parents', 'good1,bad,good2', 'johndoe'])
 
         assert result.exit_code == 0
         assert 'cannot add bad' in result.output
-        # "Parents ... added!" success message is never printed since the
-        # exception happened inside the try, before reaching typer.secho(...).
-        assert 'added!' not in result.output
+        # Only the parents that actually succeeded are listed.
+        assert 'Parents good1,good2 added!' in result.output
+
+    def test_remove_parent_failure_does_not_abort_the_rest_of_the_loop(self, runner, monkeypatch):
+        monkeypatch.setattr(student, 'LMNStudent', FakeStudent)
+
+        result = runner.invoke(student.app, ['--remove-parents', 'good1,bad,good2', 'johndoe'])
+
+        assert result.exit_code == 0
+        assert 'cannot remove bad' in result.output
+        assert 'Parents good1,good2 removed!' in result.output
 
     def test_get_parents_shows_table(self, runner, monkeypatch):
         class FakeStudentWithParents(FakeStudent):

usr/lib/python3/dist-packages/linuxmusterCli/typers/student.py

@@ -33,21 +33,27 @@ def manage(
 
     if add_parents:
         get_parents = True
-        try:
-            for parent in add_parents.split(','):
+        added = []
+        for parent in add_parents.split(','):
+            try:
                 student.add_parent(parent)
-            typer.secho(f"Parents {add_parents} added!\n", fg=typer.colors.GREEN)
-        except Exception as e:
-            typer.secho(str(e), fg=typer.colors.RED)
+                added.append(parent)
+            except Exception as e:
+                typer.secho(str(e), fg=typer.colors.RED)
+        if added:
+            typer.secho(f"Parents {','.join(added)} added!\n", fg=typer.colors.GREEN)
 
     if remove_parents:
         get_parents = True
-        try:
-            for parent in remove_parents.split(','):
+        removed = []
+        for parent in remove_parents.split(','):
+            try:
                 student.remove_parent(parent)
-            typer.secho(f"Parents {remove_parents} removed!\n", fg=typer.colors.GREEN)
-        except Exception as e:
-            typer.secho(str(e), fg=typer.colors.RED)
+                removed.append(parent)
+            except Exception as e:
+                typer.secho(str(e), fg=typer.colors.RED)
+        if removed:
+            typer.secho(f"Parents {','.join(removed)} removed!\n", fg=typer.colors.GREEN)
 
     if get_parents:
         if student.parents: