This issue is automatically created based on existing pull request: #40780: Replace all gad_* parameters in VCL
Description (*)
This makes sure that not only gad_source, but also gad_campaignid and all future gad_* tracking parameters are replaced. This way, the page will still be served by Varnish when a tracking parameter like gad_campaignid is used in the URL.
See https://support.google.com/google-ads/answer/16193746?hl=en.
Related Pull Requests
n/a
Fixed Issues (if relevant)
- Fixes magento/magento2#<issue_number>
Manual testing scenarios (*)
- Make sure you use Varnish and have the full page cache enabled.
- Flush the cache.
- Open the homepage like https://www.shop.tld/. It should load "slow" as you just flushed the cache.
- Open the homepage like https://www.shop.tld/ again. It should load fast as it is now served through Varnish.
- Open the homepage with the
gad_campaignid like https://www.shop.tld?gad_campaignid=abc.
- Without the changes to the VCL in this pull request, the homepage will load "slow" as it is not a cache hit. With this change, the homepage will load fast as it is a cache hit.
Questions or comments
Make sure to apply the VCL to your Varnish instance during your testing. It is not enough to just check out the code - you also need to apply the VCL during testing.
Contribution checklist (*)
This issue is automatically created based on existing pull request: #40780: Replace all gad_* parameters in VCL
Description (*)
This makes sure that not only
gad_source, but alsogad_campaignidand all futuregad_*tracking parameters are replaced. This way, the page will still be served by Varnish when a tracking parameter likegad_campaignidis used in the URL.See https://support.google.com/google-ads/answer/16193746?hl=en.
Related Pull Requests
n/a
Fixed Issues (if relevant)
Manual testing scenarios (*)
gad_campaignidlike https://www.shop.tld?gad_campaignid=abc.Questions or comments
Make sure to apply the VCL to your Varnish instance during your testing. It is not enough to just check out the code - you also need to apply the VCL during testing.
Contribution checklist (*)