Skip to content

[Issue] Replace all gad_* parameters in VCL #40781

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #40780: Replace all gad_* parameters in VCL


Description (*)

This makes sure that not only gad_source, but also gad_campaignid and all future gad_* tracking parameters are replaced. This way, the page will still be served by Varnish when a tracking parameter like gad_campaignid is used in the URL.

See https://support.google.com/google-ads/answer/16193746?hl=en.

Related Pull Requests

n/a

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. Make sure you use Varnish and have the full page cache enabled.
  2. Flush the cache.
  3. Open the homepage like https://www.shop.tld/. It should load "slow" as you just flushed the cache.
  4. Open the homepage like https://www.shop.tld/ again. It should load fast as it is now served through Varnish.
  5. Open the homepage with the gad_campaignid like https://www.shop.tld?gad_campaignid=abc.
  6. Without the changes to the VCL in this pull request, the homepage will load "slow" as it is not a cache hit. With this change, the homepage will load fast as it is a cache hit.

Questions or comments

Make sure to apply the VCL to your Varnish instance during your testing. It is not enough to just check out the code - you also need to apply the VCL during testing.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Ready for Confirmation

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions