fix(ember-simple-auth): don't set redirectTarget when falsy (#3012)

Author: BobrImperator

packages/ember-simple-auth/src/-internals/routing.js

@@ -16,7 +16,10 @@ export function requireAuthentication(owner, transition, extraArgs) {
         redirectTarget = transition.intent.url;
       }
     }
-    internalSession.setRedirectTarget(redirectTarget);
+
+    if (redirectTarget) {
+      internalSession.setRedirectTarget(redirectTarget);
+    }
   }
   return isAuthenticated;
 }

packages/test-esa/tests/unit/services/session-test.js

@@ -268,6 +268,12 @@ module('SessionService', function (hooks) {
           );
         });
 
+        test('when transition.intent.url is empty, redirectTarget is not set', function (assert) {
+          sessionService.requireAuthentication({ intent: { url: '' } }, 'login');
+
+          assert.ok(writeCookieStub.notCalled);
+        });
+
         test('when redirectTarget is provided it can be retrieved', function (assert) {
           let cookieName = 'ember_simple_auth-session-redirectTarget';
           sessionService.requireAuthentication(transition, 'login', { redirectTarget });