[codex] Support kubernetes v36 in Iris#5917
Closed
yonromai wants to merge 1 commit into
Closed
Conversation
49e2cb3 to
c2e28f1
Compare
c2e28f1 to
0d08222
Compare
0d08222 to
84497a9
Compare
84497a9 to
1382c98
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kubernetes==36.0.0.limit_bytestrimming.Upstream Auth Change
kubernetes==36.0.0changed the generated client auth lookup fromauthorizationtoBearerToken, but the released v36 config loaders still populateauthorization. Iris mirrors the loaded token into both keys so generated APIs authenticate and refresh hooks keep both aliases current.The core upstream quote is from the release-36.0 changelog:
Configuration auth uses 'BearerToken' instead of 'authorization' in api_key.Additional upstream evidence
BearerToken:if 'BearerToken' in self.api_key:authorization:client_configuration.api_key['authorization'] = self.tokenauthorization:client_configuration.api_key['authorization'] = self.tokenthey still write api_key['authorization']and the failure mode assilently send unauthenticated requests.headers: {}andsystem:anonymous.Validation
cd lib/iris && uv run --group dev python -m pytest --tb=short tests/cluster/providers/k8s/test_cloud_k8s_service.py(44 passed)cd lib/iris && uv run --group dev python -m pytest --tb=short tests/cluster/providers/k8s(250 passed)./infra/pre-commit.py --files lib/iris/src/iris/cluster/providers/k8s/service.py lib/iris/tests/cluster/providers/k8s/test_cloud_k8s_service.py lib/iris/pyproject.toml uv.lock(passed)iris-ciwith both auth aliases present.kubernetes 36.0.0and both auth aliases.26311058587, job77461399389.