Skip to content

MiniEngine: Frustum::ConstructOrthographicFrustum near/far plane normals point outward, inconsistent with side planes #960

Description

@Yix-dev

https://github.com/microsoft/DirectX-Graphics-Samples/blob/master/MiniEngine/Core/Math/Frustum.cpp
I assume the engine uses a righthanded coordinate system, therefore the definition of the plane normals in function void Frustum::ConstructOrthographicFrustum is inconsistent with this convention. Instead of pointing inward, the normals point outward. m_FrustumPlanes[kNearPlane] = BoundingPlane( 0.0f, 0.0f, 1.0f, -Front );
m_FrustumPlanes[kFarPlane] = BoundingPlane( 0.0f, 0.0f, -1.0f, Back );
The z values of these planes should be -1.0f and 1.0 respectively.

Metadata

Metadata

Assignees

No one assigned

    Labels

    miniengineIssues related to MiniEngine

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions