fix(terminal): guard against disposed link detector adapter#318321
Open
SpencerJung wants to merge 1 commit into
Open
fix(terminal): guard against disposed link detector adapter#318321SpencerJung wants to merge 1 commit into
SpencerJung wants to merge 1 commit into
Conversation
…t#316439) TerminalLinkDetectorAdapter._createTerminalLink was calling createInstance on a disposed InstantiationService when the terminal had been closed while link detection was in progress. - Add disposed check before createInstance call - Throw descriptive error instead of unhandled InstantiationService disposed error Fixes microsoft#316439
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @anthonykim1Matched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a disposal-state guard to prevent creating terminal links after TerminalLinkDetectorAdapter has been disposed.
Changes:
- Introduces an
isDisposedcheck on the adapter’s disposable store before creating aTerminalLink. - Throws an error when link creation is attempted after disposal.
Comment on lines
+106
to
+108
| if (this._store.isDisposed) { | ||
| throw new Error('Terminal link detector adapter has been disposed'); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #316439
Summary
TerminalLinkDetectorAdapter._createTerminalLink was calling createInstance on a disposed InstantiationService when the terminal had been closed while link detection was in progress, causing unhandled "InstantiationService has been disposed" errors.
Changes
this._store.isDisposed) before thecreateInstancecall in_createTerminalLinkVerification Evidence
npm run compile-check-ts-native: PASSED (no TypeScript errors)Checklist