Skip to content

Commit 625541e

Browse files
authored
Editor: Fix canvas reference for video rendering. (#32864)
1 parent f67c8e4 commit 625541e

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

editor/js/Menubar.Render.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ class RenderVideoDialog {
497497

498498
const qualityToBitrate = {
499499
'low': 2e6,
500-
'medium': 5e6,
500+
'medium': 5e6,
501501
'high': 10e6,
502502
'ultra': 20e6
503503
};
@@ -526,7 +526,7 @@ class RenderVideoDialog {
526526
player.render( currentTime );
527527

528528
const bitmap = await createImageBitmap( canvas );
529-
const frame = new VideoFrame( bitmap, { timestamp: i * ( 1_000_000 / fps ) } );
529+
const frame = new VideoFrame( bitmap, { timestamp: i * ( 1e6 / fps ) } );
530530

531531
videoEncoder.encode( frame, { keyFrame: i % fps === 0 } );
532532
frame.close();

editor/js/libs/app.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const APP = {
1212
const dom = document.createElement( 'div' );
1313

1414
this.dom = dom;
15+
this.canvas = null;
1516

1617
this.width = 500;
1718
this.height = 500;
@@ -26,6 +27,7 @@ const APP = {
2627

2728
renderer.dispose();
2829
dom.removeChild( renderer.domElement );
30+
this.canvas = null;
2931

3032
}
3133

@@ -49,6 +51,7 @@ const APP = {
4951
if ( project.toneMappingExposure !== undefined ) renderer.toneMappingExposure = project.toneMappingExposure;
5052

5153
dom.appendChild( renderer.domElement );
54+
this.canvas = renderer.domElement;
5255

5356
this.setScene( loader.parse( json.scene ) );
5457
this.setCamera( loader.parse( json.camera ) );

0 commit comments

Comments
 (0)