Share NetIPC C service initialization

Author: ktsaou

.agents/sow/current/SOW-0015-20260605-codacy-scope-and-maintainability.md

@@ -904,6 +904,46 @@ Validation for this increment:
 - `cd src/go && GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go test -run '^$' ./pkg/netipc/transport/windows ./pkg/netipc/service/raw ./pkg/netipc/service/apps_lookup ./pkg/netipc/service/cgroups_lookup ./pkg/netipc/service/cgroups_snapshot`: passed.
 - `git diff --check`: passed.
 
+### 2026-06-08 - Netdata PR Sonar C Service Duplication Refresh
+
+Fresh Netdata PR #22649 SonarCloud evidence after vendoring plugin-ipc commit `f5eca1e`:
+
+- SonarCloud analyzed Netdata PR head `08fcd6594fec0f5f3fa323946e35cf7354f0fe0f`.
+- SonarCloud new-code duplication improved from 1024 lines / 5.903378300472731% to:
+  - new duplicated lines: 666.
+  - new duplicated blocks: 33.
+  - new duplicated line density: 3.768247142695485%.
+- The remaining Quality Gate failure is still `new_duplicated_lines_density > 3%`.
+- Top remaining production contributors are C POSIX/Windows service pairs:
+  - `netipc_service_posix_server.c`: 61 duplicated lines.
+  - `netipc_service_win_server.c`: 61 duplicated lines.
+  - `netipc_service_posix_client.c`: 33 duplicated lines.
+  - `netipc_service_win_client.c`: 33 duplicated lines.
+  - `netipc_service_posix_client_call.c`: 32 duplicated lines.
+  - `netipc_service_win_client_call.c`: 32 duplicated lines.
+
+Implemented SDK follow-up:
+
+- Added common C service helpers for:
+  - client/server transport field conversion from typed service config.
+  - server base field initialization.
+  - server session-slot allocation.
+- Updated POSIX and Windows service client/server files to reuse those helpers.
+- Preserved platform-specific behavior:
+  - POSIX and Windows listener creation remains platform-specific.
+  - POSIX mutex and Windows critical-section setup remains platform-specific.
+  - POSIX UDS, POSIX SHM, Windows Named Pipe, and Windows SHM code paths remain platform-specific.
+  - No protocol, wire-format, or runtime contract changed.
+
+Validation for this increment:
+
+- `git diff --check`: passed.
+- `cmake --build build`: passed.
+- `/usr/bin/ctest --test-dir build --output-on-failure`: 46/46 tests passed.
+- Win11 MSYS focused C service validation from a temporary copy:
+  - `cmake --build build-msys --target test_win_service test_win_service_payload_limits test_win_service_extra`: passed.
+  - `/usr/bin/ctest --output-on-failure -R '^(test_win_service|test_win_service_payload_limits|test_win_service_extra)$'`: 3/3 tests passed.
+
 ## Validation
 
 Acceptance criteria evidence:
@@ -921,6 +961,7 @@ Acceptance criteria evidence:
 - Go apps/cgroups lookup unknown codec paths now have canonical fast paths and regression tests.
 - POSIX and Windows benchmark runners now distinguish floor/correctness failures from scheduler-stability noise using documented repeated-sample policies.
 - Netdata PR #22649 SonarCloud duplication gate was rechecked; the current SDK increment removes duplicated Go transport/service flow before re-vendoring.
+- Netdata PR #22649 SonarCloud duplication gate was rechecked after the Go increment; the remaining production C service duplication was reduced through shared service helpers.
 
 Tests or equivalent validation:
 
@@ -940,6 +981,9 @@ Tests or equivalent validation:
 - `cd src/go && go test -count=1 ./pkg/netipc/...`: passed on 2026-06-08.
 - `cd src/go && GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go test -run '^$' ./pkg/netipc/transport/windows ./pkg/netipc/service/raw ./pkg/netipc/service/apps_lookup ./pkg/netipc/service/cgroups_lookup ./pkg/netipc/service/cgroups_snapshot`: passed on 2026-06-08.
 - `git diff --check`: passed on 2026-06-08 after the Go duplication-reduction increment.
+- `cmake --build build`: passed on 2026-06-08 after the C service duplication-reduction increment.
+- `/usr/bin/ctest --test-dir build --output-on-failure`: 46/46 passed on 2026-06-08 after the C service duplication-reduction increment.
+- Win11 MSYS focused C service validation: 3/3 passed on 2026-06-08 after the C service duplication-reduction increment.
 
 Real-use evidence:
 

src/libnetdata/netipc/src/service/netipc_service_common.c

@@ -81,6 +81,42 @@ void nipc_service_common_copy_cstr_field(char *dst, size_t dst_size, const char
     dst[len] = '\0';
 }
 
+bool nipc_service_common_client_transport_fields(
+    nipc_service_common_transport_fields_t *fields,
+    const nipc_client_config_t *config)
+{
+    memset(fields, 0, sizeof(*fields));
+    if (!config)
+        return false;
+
+    fields->supported_profiles = config->supported_profiles;
+    fields->preferred_profiles = config->preferred_profiles;
+    fields->max_request_batch_items = config->max_request_batch_items;
+    fields->max_response_payload_bytes = config->max_response_payload_bytes;
+    fields->max_response_batch_items =
+        nipc_service_common_typed_response_batch_items(config->max_request_batch_items);
+    fields->auth_token = config->auth_token;
+    return true;
+}
+
+bool nipc_service_common_server_transport_fields(
+    nipc_service_common_transport_fields_t *fields,
+    const nipc_server_config_t *config)
+{
+    memset(fields, 0, sizeof(*fields));
+    if (!config)
+        return false;
+
+    fields->supported_profiles = config->supported_profiles;
+    fields->preferred_profiles = config->preferred_profiles;
+    fields->max_request_batch_items = config->max_request_batch_items;
+    fields->max_response_payload_bytes = config->max_response_payload_bytes;
+    fields->max_response_batch_items =
+        nipc_service_common_typed_response_batch_items(config->max_request_batch_items);
+    fields->auth_token = config->auth_token;
+    return true;
+}
+
 void nipc_service_common_client_init(nipc_client_ctx_t *ctx,
                                      const char *run_dir,
                                      const char *service_name)
@@ -303,6 +339,60 @@ nipc_error_t nipc_service_common_call_with_retry(
     }
 }
 
+nipc_error_t nipc_service_common_server_init_base(
+    nipc_managed_server_t *server,
+    const char *run_dir,
+    const char *service_name,
+    int worker_count,
+    uint16_t expected_method_code,
+    nipc_server_handler_fn handler,
+    void *user,
+    uint32_t max_request_payload_bytes,
+    uint32_t max_response_payload_bytes)
+{
+    if (!run_dir || !service_name || !handler)
+        return NIPC_ERR_BAD_LAYOUT;
+
+    if (worker_count < 1)
+        worker_count = 1;
+
+    nipc_service_common_copy_cstr_field(server->run_dir, sizeof(server->run_dir),
+                                        run_dir);
+    nipc_service_common_copy_cstr_field(server->service_name,
+                                        sizeof(server->service_name),
+                                        service_name);
+
+    server->handler = handler;
+    server->handler_user = user;
+    server->worker_count = worker_count;
+    server->expected_method_code = expected_method_code;
+    server->learned_request_payload_bytes =
+        max_request_payload_bytes > 0
+            ? max_request_payload_bytes
+            : NIPC_MAX_PAYLOAD_DEFAULT;
+    server->learned_response_payload_bytes =
+        max_response_payload_bytes > 0
+            ? max_response_payload_bytes
+            : NIPC_MAX_PAYLOAD_DEFAULT;
+    server->session_capacity = worker_count * 2;
+    if (server->session_capacity < 16)
+        server->session_capacity = 16;
+    server->session_count = 0;
+    server->next_session_id = 1;
+    return NIPC_OK;
+}
+
+nipc_error_t nipc_service_common_server_alloc_sessions(
+    nipc_managed_server_t *server,
+    nipc_service_common_calloc_fn calloc_fn,
+    int fault_site)
+{
+    server->sessions = calloc_fn((size_t)server->session_capacity,
+                                 sizeof(nipc_session_ctx_t *),
+                                 fault_site);
+    return server->sessions ? NIPC_OK : NIPC_ERR_OVERFLOW;
+}
+
 void nipc_service_common_server_note_request_capacity(nipc_managed_server_t *server,
                                                       uint32_t payload_len)
 {

src/libnetdata/netipc/src/service/netipc_service_common.h

@@ -45,6 +45,28 @@ typedef struct {
     uint32_t reconnect_retry_interval_ms;
 } nipc_service_common_client_ops_t;
 
+typedef void *(*nipc_service_common_calloc_fn)(size_t count,
+                                               size_t size,
+                                               int fault_site);
+
+typedef struct {
+    uint32_t supported_profiles;
+    uint32_t preferred_profiles;
+    uint32_t max_request_batch_items;
+    uint32_t max_response_payload_bytes;
+    uint32_t max_response_batch_items;
+    uint64_t auth_token;
+} nipc_service_common_transport_fields_t;
+
+#define NIPC_SERVICE_COMMON_APPLY_TRANSPORT_FIELDS(dst, fields) do { \
+    (dst)->supported_profiles = (fields)->supported_profiles; \
+    (dst)->preferred_profiles = (fields)->preferred_profiles; \
+    (dst)->max_request_batch_items = (fields)->max_request_batch_items; \
+    (dst)->max_response_payload_bytes = (fields)->max_response_payload_bytes; \
+    (dst)->max_response_batch_items = (fields)->max_response_batch_items; \
+    (dst)->auth_token = (fields)->auth_token; \
+} while (0)
+
 uint32_t nipc_service_common_next_power_of_2_u32(uint32_t n);
 bool nipc_service_common_header_payload_len(size_t payload_len,
                                             size_t *msg_len_out);
@@ -55,6 +77,12 @@ uint32_t nipc_service_common_request_payload_default(void);
 uint32_t nipc_service_common_response_payload_default(void);
 uint32_t nipc_service_common_typed_response_batch_items(uint32_t max_request_batch_items);
 void nipc_service_common_copy_cstr_field(char *dst, size_t dst_size, const char *src);
+bool nipc_service_common_client_transport_fields(
+    nipc_service_common_transport_fields_t *fields,
+    const nipc_client_config_t *config);
+bool nipc_service_common_server_transport_fields(
+    nipc_service_common_transport_fields_t *fields,
+    const nipc_server_config_t *config);
 
 void nipc_service_common_client_init(nipc_client_ctx_t *ctx,
                                      const char *run_dir,
@@ -89,6 +117,20 @@ void nipc_service_common_server_note_request_capacity(nipc_managed_server_t *ser
                                                       uint32_t payload_len);
 void nipc_service_common_server_note_response_capacity(nipc_managed_server_t *server,
                                                        uint32_t payload_len);
+nipc_error_t nipc_service_common_server_init_base(
+    nipc_managed_server_t *server,
+    const char *run_dir,
+    const char *service_name,
+    int worker_count,
+    uint16_t expected_method_code,
+    nipc_server_handler_fn handler,
+    void *user,
+    uint32_t max_request_payload_bytes,
+    uint32_t max_response_payload_bytes);
+nipc_error_t nipc_service_common_server_alloc_sessions(
+    nipc_managed_server_t *server,
+    nipc_service_common_calloc_fn calloc_fn,
+    int fault_site);
 void nipc_service_common_prepare_response_header(const nipc_header_t *request_hdr,
                                                  nipc_header_t *resp_hdr);
 void nipc_service_common_apply_dispatch_result(nipc_managed_server_t *server,

src/libnetdata/netipc/src/service/netipc_service_posix_client.c

@@ -18,18 +18,12 @@ static nipc_uds_client_config_t service_client_config_to_transport(
     const nipc_client_config_t *config)
 {
     nipc_uds_client_config_t transport = {0};
+    nipc_service_common_transport_fields_t fields;
 
-    if (!config)
+    if (!nipc_service_common_client_transport_fields(&fields, config))
         return transport;
 
-    transport.supported_profiles = config->supported_profiles;
-    transport.preferred_profiles = config->preferred_profiles;
-    transport.max_request_batch_items = config->max_request_batch_items;
-    transport.max_response_payload_bytes = config->max_response_payload_bytes;
-    transport.max_response_batch_items =
-        nipc_service_common_typed_response_batch_items(config->max_request_batch_items);
-    transport.auth_token = config->auth_token;
-
+    NIPC_SERVICE_COMMON_APPLY_TRANSPORT_FIELDS(&transport, &fields);
     return transport;
 }
 
@@ -56,17 +50,12 @@ void nipc_service_platform_server_config_from_service(
     const nipc_server_config_t *config)
 {
     memset(transport, 0, sizeof(*transport));
+    nipc_service_common_transport_fields_t fields;
 
-    if (!config)
+    if (!nipc_service_common_server_transport_fields(&fields, config))
         return;
 
-    transport->supported_profiles = config->supported_profiles;
-    transport->preferred_profiles = config->preferred_profiles;
-    transport->max_request_batch_items = config->max_request_batch_items;
-    transport->max_response_payload_bytes = config->max_response_payload_bytes;
-    transport->max_response_batch_items =
-        nipc_service_common_typed_response_batch_items(config->max_request_batch_items);
-    transport->auth_token = config->auth_token;
+    NIPC_SERVICE_COMMON_APPLY_TRANSPORT_FIELDS(transport, &fields);
 }
 
 /* ------------------------------------------------------------------ */

src/libnetdata/netipc/src/service/netipc_service_posix_server.c

@@ -111,43 +111,21 @@ nipc_error_t nipc_service_platform_server_init_raw(
     __atomic_store_n(&server->running, false, __ATOMIC_RELAXED);
     server->acceptor_started = false;
 
-    if (!run_dir || !service_name || !config || !handler)
+    if (!config)
         return NIPC_ERR_BAD_LAYOUT;
 
-    if (worker_count < 1)
-        worker_count = 1;
-
-    nipc_service_common_copy_cstr_field(server->run_dir, sizeof(server->run_dir),
-                                        run_dir);
-    nipc_service_common_copy_cstr_field(server->service_name,
-                                        sizeof(server->service_name),
-                                        service_name);
-
-    server->handler = handler;
-    server->handler_user = user;
-    server->worker_count = worker_count;
-    server->expected_method_code = expected_method_code;
+    nipc_error_t ierr = nipc_service_common_server_init_base(
+        server, run_dir, service_name, worker_count, expected_method_code,
+        handler, user, config->max_request_payload_bytes,
+        config->max_response_payload_bytes);
+    if (ierr != NIPC_OK)
+        return ierr;
     server->base_config = *config;
-    server->learned_request_payload_bytes =
-        config->max_request_payload_bytes > 0
-            ? config->max_request_payload_bytes
-            : NIPC_MAX_PAYLOAD_DEFAULT;
-    server->learned_response_payload_bytes =
-        config->max_response_payload_bytes > 0
-            ? config->max_response_payload_bytes
-            : NIPC_MAX_PAYLOAD_DEFAULT;
-
-    /* Initialize session tracking */
-    server->session_capacity = worker_count * 2; /* room for slots being reaped */
-    if (server->session_capacity < 16)
-        server->session_capacity = 16;
-    server->sessions = nipc_service_posix_calloc((size_t)server->session_capacity,
-                              sizeof(nipc_session_ctx_t *),
-                              NIPC_POSIX_SERVICE_TEST_FAULT_SERVER_SESSIONS_CALLOC_INTERNAL);
-    if (!server->sessions)
-        return NIPC_ERR_OVERFLOW;
-    server->session_count = 0;
-    server->next_session_id = 1; /* spec: monotonic counter starting at 1 */
+    ierr = nipc_service_common_server_alloc_sessions(
+        server, nipc_service_posix_calloc,
+        NIPC_POSIX_SERVICE_TEST_FAULT_SERVER_SESSIONS_CALLOC_INTERNAL);
+    if (ierr != NIPC_OK)
+        return ierr;
     pthread_mutex_init(&server->sessions_lock, NULL);
 
     /* Clean up stale SHM regions from previous crashes (spec requirement:

src/libnetdata/netipc/src/service/netipc_service_win_client.c

@@ -21,18 +21,12 @@ static nipc_np_client_config_t service_client_config_to_transport(
     const nipc_client_config_t *config)
 {
     nipc_np_client_config_t transport = {0};
+    nipc_service_common_transport_fields_t fields;
 
-    if (!config)
+    if (!nipc_service_common_client_transport_fields(&fields, config))
         return transport;
 
-    transport.supported_profiles = config->supported_profiles;
-    transport.preferred_profiles = config->preferred_profiles;
-    transport.max_request_batch_items = config->max_request_batch_items;
-    transport.max_response_payload_bytes = config->max_response_payload_bytes;
-    transport.max_response_batch_items =
-        nipc_service_common_typed_response_batch_items(config->max_request_batch_items);
-    transport.auth_token = config->auth_token;
-
+    NIPC_SERVICE_COMMON_APPLY_TRANSPORT_FIELDS(&transport, &fields);
     return transport;
 }
 
@@ -59,17 +53,12 @@ void nipc_service_platform_server_config_from_service(
     const nipc_server_config_t *config)
 {
     memset(transport, 0, sizeof(*transport));
+    nipc_service_common_transport_fields_t fields;
 
-    if (!config)
+    if (!nipc_service_common_server_transport_fields(&fields, config))
         return;
 
-    transport->supported_profiles = config->supported_profiles;
-    transport->preferred_profiles = config->preferred_profiles;
-    transport->max_request_batch_items = config->max_request_batch_items;
-    transport->max_response_payload_bytes = config->max_response_payload_bytes;
-    transport->max_response_batch_items =
-        nipc_service_common_typed_response_batch_items(config->max_request_batch_items);
-    transport->auth_token = config->auth_token;
+    NIPC_SERVICE_COMMON_APPLY_TRANSPORT_FIELDS(transport, &fields);
 }
 
 /* ------------------------------------------------------------------ */