fix(build): avoid replacing unexpected words (#3671)

Author: 9romise

src/build/config.ts

@@ -48,6 +48,12 @@ export function baseBuildConfig(nitro: Nitro) {
     _tasks: nitro.options.experimental.tasks,
   };
 
+  // https://github.com/rollup/plugins/tree/master/packages/replace#delimiters
+  const replaceDelimiters: [string, string] = [
+    String.raw`\b`,
+    String.raw`(?![\w.$])`,
+  ];
+
   const replacements = {
     "typeof window": '"undefined"',
     _import_meta_url_: "import.meta.url",
@@ -105,6 +111,7 @@ export function baseBuildConfig(nitro: Nitro) {
     isNodeless,
     buildEnvVars,
     staticFlags,
+    replaceDelimiters,
     replacements,
     env,
     aliases,

src/build/rolldown/config.ts

@@ -36,6 +36,7 @@ export const getRolldownConfig = (nitro: Nitro): RolldownOptions => {
       ...(baseBuildPlugins(nitro, base) as RolldownPlugin[]),
       // https://github.com/rolldown/rolldown/issues/4257
       replace({
+        delimiters: base.replaceDelimiters,
         preventAssignment: true,
         values: base.replacements,
       }) as RolldownPlugin,

src/build/rollup/config.ts

@@ -47,7 +47,11 @@ export const getRollupConfig = (nitro: Nitro): RollupConfig => {
         ...nitro.options.esbuild?.options,
       }),
       alias({ entries: base.aliases }),
-      replace({ preventAssignment: true, values: base.replacements }),
+      replace({
+        delimiters: base.replaceDelimiters,
+        preventAssignment: true,
+        values: base.replacements,
+      }),
       nodeResolve({
         extensions: base.extensions,
         preferBuiltins: !!nitro.options.node,

src/build/vite/rollup.ts

@@ -54,7 +54,11 @@ export const getViteRollupConfig = (
         virtualBundlePlugin(ctx._serviceBundles),
       ...baseBuildPlugins(nitro, base),
       alias({ entries: base.aliases }),
-      replace({ preventAssignment: true, values: base.replacements }),
+      replace({
+        delimiters: base.replaceDelimiters,
+        preventAssignment: true,
+        values: base.replacements,
+      }),
       inject(base.env.inject),
     ].filter(Boolean) as RollupPlugin[],
     treeshake: {

test/fixture/routes/replace.ts

@@ -0,0 +1,5 @@
+function foo(options) {
+  const { window: window$1 = globalThis } = options;
+
+  return typeof window$1 === "function";
+}

test/presets/vercel.test.ts

@@ -174,6 +174,10 @@ describe("nitro:preset:vercel", async () => {
                 "dest": "/route-group",
                 "src": "/route-group",
               },
+              {
+                "dest": "/replace",
+                "src": "/replace",
+              },
               {
                 "dest": "/raw",
                 "src": "/raw",
@@ -550,6 +554,7 @@ describe("nitro:preset:vercel", async () => {
             "functions/prerender-custom.html.func (symlink)",
             "functions/prerender.func (symlink)",
             "functions/raw.func (symlink)",
+            "functions/replace.func (symlink)",
             "functions/route-group.func (symlink)",
             "functions/rules/[...slug].func (symlink)",
             "functions/rules/_/cached/[...]-isr.func (symlink)",