feat: Node.js Alpine arm64 Unofficial Builds#2476
Open
nschonni wants to merge 2 commits intonodejs:mainfrom
Open
feat: Node.js Alpine arm64 Unofficial Builds#2476nschonni wants to merge 2 commits intonodejs:mainfrom
nschonni wants to merge 2 commits intonodejs:mainfrom
Conversation
nschonni
force-pushed
the
arm64-pre-built
branch
from
a2acc6b to
e875511
Compare
nschonni
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
nschonni
force-pushed
the
arm64-pre-built
branch
2 times, most recently
from
076322d to
924f032
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
@MikeMcC399 thanks for pointing that out. I'm just trying to see if I can get the matrix to run/generate on x64/ARM for now |
Contributor
Nice enhancement! It's just a bit confusing when there are unrelated issues in the background causing failures 🙁 But anyway the key issue is a subject for other discussions! Hopefully Ubuntu can recover soon. |
Member
Author
|
Flipped out of review, as I figured out how to get the generated matrix to run on both x64 and ARM64 ubuntu for our smoke testing. Might be a concern around increasing the matrix size, but the jobs aren't particularly long |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2475
Motivation and Context
I'm not sure if this actually is better than dropping the unofficial builds for all the Alpine builds, but opening as a draft.
Testing Details
I have no ARM64 devices to try the compilation on
Example Output(if appropriate)
Types of changes
Checklist