Skip to content

Commit 67f45f3

Browse files
author
Your Name
committed
refactor: fix failed components test, remove error translations from locale files
1 parent d44a199 commit 67f45f3

26 files changed

Lines changed: 9 additions & 36 deletions

app/components/AccountItem.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ function formatDate(value: string): string {
229229
</script>
230230

231231
<template>
232-
<li class="rounded-md border border-border bg-bg-subtle px-3 py-3 sm:px-4">
232+
<div class="rounded-md border border-border bg-bg-subtle px-3 py-3 sm:px-4">
233233
<div class="flex items-start justify-between gap-3">
234234
<div class="min-w-0">
235235
<div class="flex items-center gap-3 min-w-0">
@@ -364,5 +364,5 @@ function formatDate(value: string): string {
364364
</p>
365365
</div>
366366
</div>
367-
</li>
367+
</div>
368368
</template>

app/components/Compare/FacetSelector.vue

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,24 +101,21 @@ function deselectAllFacet(category: string) {
101101
:aria-labelledby="`facet-category-label-${category}`"
102102
data-facet-category-facets
103103
>
104-
<label
104+
<button
105105
v-for="facet in facetsByCategory[category]"
106106
:key="facet.id"
107+
role="checkbox"
108+
:aria-checked="isFacetSelected(facet.id)"
107109
:title="facet.comingSoon ? $t('compare.facets.coming_soon') : facet.description"
108-
class="inline-flex items-center gap-1 px-1.5 rounded border transition-colors text-fg-subtle bg-bg-subtle border-border-subtle hover:(text-fg-muted border-border) has-[:checked]:(text-fg-muted bg-fg/10 border-fg/20 hover:(bg-fg/20 text-fg/50)) has-[:focus-visible]:(outline outline-accent/70)"
110+
:disabled="facet.comingSoon"
111+
class="inline-flex items-center gap-1 px-1.5 rounded border transition-colors text-fg-subtle bg-bg-subtle border-border-subtle hover:(text-fg-muted border-border) aria-checked:(text-fg-muted bg-fg/10 border-fg/20 hover:(bg-fg/20 text-fg/50)) focus-visible:(outline outline-accent/70)"
109112
:class="
110113
facet.comingSoon
111114
? 'cursor-not-allowed text-fg-subtle/50 bg-bg-subtle border-border-subtle hover:(text-fg-subtle/50 border-border-subtle)'
112115
: 'cursor-pointer'
113116
"
117+
@click="toggleFacet(facet.id)"
114118
>
115-
<input
116-
type="checkbox"
117-
class="sr-only"
118-
:checked="isFacetSelected(facet.id)"
119-
:disabled="facet.comingSoon"
120-
@change="toggleFacet(facet.id)"
121-
/>
122119
<span
123120
v-if="!facet.comingSoon"
124121
aria-hidden="true"
@@ -128,7 +125,7 @@ function deselectAllFacet(category: string) {
128125
<span v-if="facet.comingSoon" class="text-4xs"
129126
>({{ $t('compare.facets.coming_soon') }})</span
130127
>
131-
</label>
128+
</button>
132129
</div>
133130
</div>
134131
</div>

i18n/locales/ar-EG.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@
8282
"cancel": "إلغاء",
8383
"save": "حفظ",
8484
"edit": "تعديل",
85-
"error": "خطأ",
8685
"view_on": {
8786
"gitlab": "عرض على GitLab",
8887
"bitbucket": "عرض على Bitbucket",

i18n/locales/az-AZ.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@
193193
"cancel": "Ləğv et",
194194
"save": "Saxla",
195195
"edit": "Redaktə et",
196-
"error": "Xəta",
197196
"view_on": {
198197
"npm": "npm-də bax",
199198
"github": "GitHub-da bax"

i18n/locales/bg-BG.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
"cancel": "Отказ",
157157
"save": "Запазване",
158158
"edit": "Редактиране",
159-
"error": "Грешка",
160159
"view_on": {
161160
"npm": "преглед в npm",
162161
"github": "Преглед в GitHub"

i18n/locales/cs-CZ.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,6 @@
323323
"cancel": "Zrušit",
324324
"save": "Uložit",
325325
"edit": "Upravit",
326-
"error": "Chyba",
327326
"view_on": {
328327
"npm": "Zobrazit na npm",
329328
"github": "Zobrazit na GitHubu",

i18n/locales/de.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,6 @@
322322
"cancel": "Abbrechen",
323323
"save": "Speichern",
324324
"edit": "Bearbeiten",
325-
"error": "Fehler",
326325
"view_on": {
327326
"npm": "Auf npm ansehen",
328327
"github": "Auf GitHub ansehen",

i18n/locales/en.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@
327327
"cancel": "Cancel",
328328
"save": "Save",
329329
"edit": "Edit",
330-
"error": "Error",
331330
"view_on": {
332331
"npm": "View on npm",
333332
"github": "View on GitHub",

i18n/locales/es.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@
211211
"cancel": "Cancelar",
212212
"save": "Guardar",
213213
"edit": "Editar",
214-
"error": "Error",
215214
"view_on": {
216215
"npm": "ver en npm",
217216
"github": "Ver en GitHub",

i18n/locales/fr-FR.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,6 @@
324324
"cancel": "Annuler",
325325
"save": "Enregistrer",
326326
"edit": "Modifier",
327-
"error": "Erreur",
328327
"view_on": {
329328
"npm": "voir sur npm",
330329
"github": "Voir sur GitHub",

0 commit comments

Comments
 (0)