#4236: Fix file touch after resolving path#5168
Conversation
|
🚀 Performance AnalysisAll benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information. Click to see the detailed report
✅ Performance gain: |
akmhatey-ai
left a comment
There was a problem hiding this comment.
Reviewed current head 0d66148.
The patch is limited to eo-runtime/src/main/eo/fs/file.eo and does the two things needed for #4236: it changes tests-resolves-and-touches from a disabled test to an enabled +> test, and it makes the resolved nested directory before creating the temp file there. The assertion now checks that the touched file exists and that its dirname equals the resolved directory path, so the test covers touch after path resolution without relying on substring matching.
Validation:
- Issue and same-scope PR readback: #5168 is the only open PR I found for #4236/resolves-and-touches.
- GitHub Actions are green for mvn on Ubuntu, macOS, and Windows, plus qulice, integration, snippets, reuse, xcop, and the rest of the runtime checks.
- The only red check, pr-size, fails before running because GitHub cannot resolve maidsafe/pr_size_checker; that is an infrastructure/action-reference failure, not a patch failure.
- git diff --check origin/master...HEAD passed.
- Diff-only Gitleaks over origin/master...HEAD found no leaks.
- Local source review confirmed the new test uses existing fs.path dirname and fs.dir tmpfile patterns.
Local limitation: I did not run Maven or EO tests on this host because Java, Maven, and eo are not installed here.



Summary
tests-resolves-and-touchesforfs.file.touchworks afterresolved.@todo #4096marker.Test plan
mvn -pl eo-runtime test -Dtest="EOfileTest#tests_resolves_and_touches"mvn clean install -PskipITsmvn clean install -Pquliceon Ubuntu 24.04 with OpenJDK 21Closes #4236.