Skip to content

#4236: Fix file touch after resolving path #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikdenalb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#4236: Fix file touch after resolving path #5168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e403397
#4236: enable and fix tests-resolves-and-touches
nikdenalb May 22, 2026
0d66148
#4236: remove obsolete tests-resolves-and-touches todo
nikdenalb May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions eo-runtime/src/main/eo/fs/file.eo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,22 +288,14 @@
(tmpdir.as-path.resolved "foo").@.tmpfile > @

# Tests that resolving nested paths and touching files works correctly.
# @todo #4096:30min Enable tests-resolves-and-touches unit test.
# Now its disabled because of: "Can't #take("path"), the attribute is absent among other test 34
# attrs. After we fix it, we should enable the test.
[] > tests-resolves-and-touches
seq > @
*
resolved.deleted.made
and.
f.exists
contains.
f.path
joined.
path.separator
* "foo" "bar"
(tmpdir.as-path.resolved "foo/bar").@ > resolved
resolved.tmpfile > f
[] +> tests-resolves-and-touches
and. > @
f.exists
eq.
(Q.fs.path f.path).dirname
resolved.path
resolved.deleted.made.tmpfile > f
(tmpdir.as-path.resolved "foo/bar").as-dir > resolved

# Tests that moving a file to a new location works correctly.
[] +> tests-moves-a-file
Expand Down
Loading