Fix 1429#1430
Merged
Merged
Conversation
This contains a test for the intitial problem, and several other problematic examples. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The assertion in [Subst.resolved_signature_fragment] at the [`Root (`ModuleType p)] case assumed the named module type at the LHS of a [subst] could never itself be substituted. The fix is to raise `Invalidated` which unresolves the fragment so the code can continue. It will subsequently be removed from the signature by the substitution. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Lower bound is now 4.11. Bumped macos latest to 5.4. Keeping ubuntu latest on 5.3 as bisect_ppx is unavailable for 5.4
It was removing bisect_ppx from the opam file, but we've removed it anyway.
panglesd
approved these changes
May 11, 2026
Collaborator
panglesd
left a comment
panglesd
left a comment
There was a problem hiding this comment.
I haven't investigated enough the issue to say this is the correct fix, or to provide a better one. But I still can say that it is better than before, and should go in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression, but due to code that's been there a while. We're just exercising it more with the fix for #930.