Skip to content

[confighttp] HTTP compression empty settings & garbage data report #15122

@jmacd

Description

@jmacd

Component(s)

config/confighttp

What happened?

Describe the bug

See #13228 (comment)

three related issues are described,
two are about disabling compression with "" or "identity"
one is about garbage data causing 500 not 400 (and logging a panic)

These do not appear to crash the server (i.e., panic is handled), so I consider this not a security bug, but 500 is not a correct response.

Collector version

current

Environment information

I have confirmed there are a few bugs, here, all related to (iiuc) disabling compression at the server.

OpenTelemetry Collector configuration

First bug relates to `compression: ""`. The empty string is invalid, and probably shouldn't be.
Handling of "identity: or "" Content-Encoding is incorrect.

Log output

Additional context

#14459 (comment)

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions