Skip to content

Commit bc542ae

Browse files
authored
Fix race condition causing flaky PeriodicMetricReaderTest (#8317)
1 parent 6f180cb commit bc542ae

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/PeriodicMetricReader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,17 +214,17 @@ CompletableResultCode doRun() {
214214
}
215215
if (metricData.isEmpty()) {
216216
logger.log(Level.FINE, "No metric data to export - skipping export.");
217-
flushResult.succeed();
218217
exportAvailable.set(true);
218+
flushResult.succeed();
219219
} else {
220220
CompletableResultCode result = exporter.export(metricData);
221221
result.whenComplete(
222222
() -> {
223223
if (!result.isSuccess()) {
224224
logger.log(Level.FINE, "Exporter failed");
225225
}
226-
flushResult.succeed();
227226
exportAvailable.set(true);
227+
flushResult.succeed();
228228
});
229229
}
230230
} catch (Throwable t) {

0 commit comments

Comments
 (0)