Skip to content

Commit 62f9b5b

Browse files
fix(config): clarify deflate compression gating
1 parent d81611a commit 62f9b5b

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

  • opentelemetry-sdk/src/opentelemetry/sdk/_configuration

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_common.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
from opentelemetry.sdk._configuration._exceptions import ConfigurationError
2121
from opentelemetry.util._importlib_metadata import entry_points
2222

23-
from opentelemetry.sdk._configuration._exceptions import ConfigurationError
24-
2523
_logger = logging.getLogger(__name__)
2624

2725

@@ -90,17 +88,17 @@ def _map_compression(
9088
return None
9189

9290
value_lower = value.lower()
93-
supports_deflate = allow_deflate and hasattr(compression_enum, "Deflate")
91+
supports_deflate = hasattr(compression_enum, "Deflate")
9492

9593
if value_lower == "none":
9694
return None
9795
if value_lower == "gzip":
9896
return compression_enum.Gzip # type: ignore[attr-defined]
99-
if value_lower == "deflate" and supports_deflate:
97+
if value_lower == "deflate" and allow_deflate and supports_deflate:
10098
return compression_enum.Deflate # type: ignore[attr-defined]
10199

102100
supported_values = ["'gzip'", "'none'"]
103-
if supports_deflate:
101+
if allow_deflate and supports_deflate:
104102
supported_values.insert(1, "'deflate'")
105103

106104
raise ConfigurationError(

0 commit comments

Comments
 (0)