From 1f9b8bea7d06241636a0ebffb3353fe5cfb81258 Mon Sep 17 00:00:00 2001 From: robobun <117481402+robobun@users.noreply.github.com> Date: Tue, 19 May 2026 07:52:37 +0000 Subject: [PATCH] SSLConfig: fix stale allocator names in dupe_z doc comments bun_core::dupe_z allocates with default_alloc::malloc and free_sensitive_cstr frees with default_alloc::free. Two doc comments in SSLConfig.rs still said mi_free and mimalloc. Update them to match the block comment above them. The security_scanner.rs change this PR first carried is already on main. #40478 returns early on the start() error before the deref, and the RefPtr locals release on Drop. --- src/runtime/socket/SSLConfig.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/runtime/socket/SSLConfig.rs b/src/runtime/socket/SSLConfig.rs index 3823142abe5f..507c4d7cc942 100644 --- a/src/runtime/socket/SSLConfig.rs +++ b/src/runtime/socket/SSLConfig.rs @@ -58,13 +58,13 @@ impl From for ReadFromBlobError { // so `free_sensitive` would not pair with `Box`-owned memory. // ────────────────────────────────────────────────────────────────────────── -/// `ZBox` is global-allocator memory; re-allocate via `dupe_z` so `mi_free` can free it. +/// `ZBox` is global-allocator memory; re-allocate via `dupe_z` so `free_sensitive` can free it. #[inline] fn zbox_into_raw(z: &bun_core::ZBox) -> *const c_char { bun_core::dupe_z(z.as_bytes()) } -/// `dupeZ` a byte slice into a fresh mimalloc allocation. +/// `dupeZ` a byte slice into a fresh default-allocator allocation. #[inline] fn dupe_z(bytes: &[u8]) -> *const c_char { bun_core::dupe_z(bytes)