compat: url 100% by snoglobe · Pull Request #15752 · oven-sh/bun

snoglobe · 2024-12-14T00:11:16Z

What does this PR do?

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

robobun · 2024-12-14T00:11:26Z

❌ @snoglobe, your commit a93ce9f has 33 failures in #7950:

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline

test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64

test/v8/v8.test.ts - timeout on 🐧 12 aarch64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 12 aarch64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 20.04 aarch64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 22.04 aarch64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 12 x64-baseline

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 20.04 x64-baseline

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 22.04 x64-baseline

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 24.04 x64-baseline

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 22.04 x64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 20.04 x64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 24.04 x64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 12 x64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 3.20 aarch64

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 3.20 x64-baseline

test/js/third_party/remix/remix.test.ts - annotation error on 🐧 3.20 x64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 aarch64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 aarch64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 aarch64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 aarch64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 22.04 x64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 x64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 12 x64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 20.04 x64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 aarch64

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64

test/regression/issue/ctrl-c.test.ts - 1 failing on 🐧 24.04 x64

test/regression/issue/09041.test.ts - 1 failing on 🐧 24.04 x64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 x64-baseline

test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 24.04 aarch64

test/js/node/test/parallel/test-timers-immediate-queue.js - code 1 on 🐧 24.04 aarch64

test/js/deno/performance/performance.test.ts - 1 failing on 🐧 24.04 x64-baseline

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64

test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline

test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64

test/bundler/bundler_compile.test.ts - 1 failing on 🐧 12 aarch64

test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64-baseline

test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64

test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline

test/js/node/fs/fs.test.ts - 1 failing on 🐧 22.04 x64

test/js/web/url/url.windows.test.js - 3 failing on 🪟 2019 x64

test/js/web/url/url.windows.test.js - 3 failing on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64

test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64-baseline

test/js/third_party/pino/pino.test.js - 1 failing on 🍎 14 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🍎 13 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 20.04 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 12 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 22.04 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 24.04 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 12 x64-baseline

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 24.04 x64-baseline

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 20.04 x64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 22.04 x64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 24.04 x64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 3.20 aarch64

test/js/third_party/pino/pino.test.js - 1 failing on 🐧 3.20 x64

test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 24.04 x64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 3.20 x64-baseline

test/js/node/test/parallel/test-url-pathtofileurl.js - code 1 on 🐧 3.20 x64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 24.04 x64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 3.20 x64-baseline

test/js/node/test/parallel/test-url-format-whatwg.js - code 1 on 🐧 3.20 x64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 24.04 x64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 3.20 x64-baseline

test/js/node/test/parallel/test-url-fileurltopath.js - code 1 on 🐧 3.20 x64

test/js/node/url/url-parse-format.test.js - 1 failing on 🍎 14 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🪟 2019 x64

test/js/node/url/url-parse-format.test.js - 1 failing on 🪟 2019 x64-baseline

test/js/node/url/url-parse-format.test.js - 1 failing on 🍎 13 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 20.04 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 12 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 22.04 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 24.04 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 12 x64-baseline

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 22.04 x64-baseline

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 24.04 x64-baseline

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 20.04 x64-baseline

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 12 x64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 20.04 x64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 22.04 x64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 24.04 x64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 3.20 aarch64

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 3.20 x64-baseline

test/js/node/url/url-parse-format.test.js - 1 failing on 🐧 3.20 x64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🍎 14 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🪟 2019 x64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🪟 2019 x64-baseline

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🍎 13 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 12 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 24.04 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 20.04 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 22.04 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 12 x64-baseline

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 22.04 x64-baseline

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 24.04 x64-baseline

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 20.04 x64-baseline

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 12 x64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 20.04 x64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 24.04 x64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 22.04 x64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 3.20 aarch64

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 3.20 x64-baseline

test/js/node/test/parallel/test-url-parse-query.js - code 1 on 🐧 3.20 x64

snoglobe · 2024-12-14T00:12:29Z

TODO:

modify tests to not require node:test
clean up code

kravetsone · 2024-12-14T12:30:26Z

TODO:

modify tests to not require node:test

clean up code

Did Bun plans to do node:test shim?
Looks fine for cross-runtime tests

jbergstroem · 2024-12-17T10:27:11Z

Did Bun plans to do node:test shim? Looks fine for cross-runtime tests

#5090

snoglobe added 2 commits December 10, 2024 14:54

100% punycode

1de386b

init

a93ce9f

snoglobe changed the title ~~compat: url 100$~~ compat: url 100% Dec 14, 2024

Jarred-Sumner closed this May 19, 2025

Navigation Menu

Repository navigation

compat: url 100% - #15752

compat: url 100%#15752
snoglobe wants to merge 2 commits into
mainfrom
url

snoglobe commented Dec 14, 2024

Uh oh!

robobun commented Dec 14, 2024 •

edited

Loading

Uh oh!

snoglobe commented Dec 14, 2024 •

edited by RiskyMH

Loading

Uh oh!

kravetsone commented Dec 14, 2024

Uh oh!

jbergstroem commented Dec 17, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

snoglobe commented Dec 14, 2024

What does this PR do?

How did you verify your code works?

Uh oh!

robobun commented Dec 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snoglobe commented Dec 14, 2024 • edited by RiskyMH Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kravetsone commented Dec 14, 2024

Uh oh!

jbergstroem commented Dec 17, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robobun commented Dec 14, 2024 •

edited

Loading

snoglobe commented Dec 14, 2024 •

edited by RiskyMH

Loading