Release 4.5.0

[pascalwengerter]

PRs to merge

• Export translations of search app #5956
• Use default app from app provider and early returns in fileActions #5970
• Automatically show oC10 apps in app switcher menu #5996
• accentuate new files #6020 (since @fschade pulled some last-minute magic)

Release checklist

• pin release issue @pascalwengerter
• prepare release rc: @pascalwengerter
  • create a branch release-4.5.0 @pascalwengerter
  • update the version in packages/web-integration-oc10/appinfo/info.xml @pascalwengerter
  • update the version in package.json @pascalwengerter
  • update the version in sonar-project.properties @pascalwengerter
  • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @pascalwengerter
  • update the ocis commit id in .drone.env to the most recent one from ocis master (i.e. let the web UI tests run on most recent ocis master) @pascalwengerter
  • commit, push and create draft PR for this branch @pascalwengerter
• create pre release tag v4.5.0-rc1 from the release branch @pascalwengerter
• smoke test
  • against oCIS @ScharfViktor
  • against oc10 standalone @pascalwengerter
  • against oc10 as app installation @kulmann
  • against oCIS wopi example / app provider
• if needed, fix issues or write down known issues
• update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
• Make sure translations are up to date
• repeat above steps if a new rc is needed
• Run translations sync job once again
• go to the releases section and click Draft a new Release. Use v4.5.0 as a tag (the v prefix is important) and 4.5.0 as name and publish it
• ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
• merge release branch Prepare 4.5.0 release #6032 back to master (CI must be green)

[pascalwengerter]

Smoke test standalone against oc10

• ❌ as admin - upload 20.000 files in 7 folders to home (Firefox on Ubuntu)

  • upload via New files button just completely freezes the tab and doesn't even start uploading according to backend logs
  • upload via Dropzone takes forever, has all CPUs at 100% and eventually doesn't upload anything anymore according to backend logs

• ✔️ as admin - share the folder as viewer

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, good

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop doesnt work, which is acceptable

• ✔️ as alice - copy 100 files from share to home
  move from shared folder makes browser lag alot sometimes freeze

• ✔️ as admin - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as admin - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as admin - share folder with alice again, but as editor

• ✔️ as alice - rename file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as admin - add file

• ✔️ as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as alice - create public link on any folder

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ✔️ as alice download newest version of text file

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is updated

• ✔️ as alice - upload avatar in classic UI

  • login as admin, having a share with alice
  • shared with others page loads and shows avatars

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with admin

[ScharfViktor]

SmokeTest against ocis

branch: v4.5.0-rc1

Case 1: admin share folder(with file) to marie:

Admin:

• upload big file 30gb - backend error: 507 {"level":"error","service":"storage","pkg":"rgrpc","error":"error: insufficient storage: quota exceeded","time":"2021-11-16T13:24:25Z","caller":"/go/pkg/mod/github.com/cs3org/reva@v1.12.0/internal/grpc/services/storageprovider/storageprovider.go:353","message":"insufficient storage"} ocis_1 | {"level":"error","service":"storage","pkg":"rhttp","host":"127.0.0.1","method":"PUT","uri":"/remote.php/webdav/temp_30GB_file","url":"/remote.php/webdav/temp_30GB_file","proto":"HTTP/1.1","status":507,"size":0,"start":"16/Nov/2021:13:24:25 +0000","end":"16/Nov/2021:13:24:25 +0000","time_ns":4386500,"time":"2021-11-16T13:24:25Z","message":"http"}
• upload big file 10gb - very slow
• upload folder with 848 files.
• Check pagination, count items per page.
• upload folder(drag folder) "folder_to_share" with file.pdf
• share folder "folder_to_share" to marie with edit right

Marie:

• accept "folder_to_share"
• rename "folder_to_share" (?admin don't see)
• upload new file "file.txt" to "folder_to_share" (admin see new file)
• rename file.pdf (use rigth click) (admin see that file changed name)
• try to move "folder_to_share" to "/" (400)
• copy "folder_to_share" to "/"

Admin:

• add new file.jpeg to "folder_to_share" (marie can see file without access)
• move file.pdf to "/" (marie can not see file.pdf)
• add new "file.txt" create new version. (marie can see new version)

Marie:

• can download both versions (!error 501)
• restore old version

Admin:

• change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

• decline folder (but folder exist in Shares - bug) - existing bug

Admin:

• delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Admin:

• upload file.jpeg
• share file.jpeg to marie with rigth viewer (use main menu. find marie by email marie@example.org)

Marie:

• accept file (marie can open/download/copy file but cannot delete/move/rename)
• copy file to "/"
• open file in Mediaviewer
• download file

Admin:

• change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)

Marie:

• rename file (admin don't see)

Admin:

• unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

• create folder "for upload"
• add link with name "to_upload" with role "Uploader" with pass and expiration date
• open link (can only upload)
• upload file (admin can see new file)
• refresh page(page is empty)
• change share "for upload" from "Uploader" to "edit"
• open old link (it work as upload)
• open new link (can open/download/copy/rename/move files)
• admin add new file to "for upload"
• refresh link (file exist)
• admin change pass (refresh link)

Case 4: admin create link to file

Admin:

• create file png

• add link with main menu

• open link(can open, download, see) in the incognito tab
  

• change link, add pass

• refresh page (input pass)

• delete link

• refresh page (resource not found)

• delete file

• restore

• delete

• Empty trash

Case 5: create new user:

Admin:

• create new account "tom"

Tom:

• go to account
• change language

Admin:

• block user (Login Error access denied)
• delete user (Logon failed)
• logout

Remarks: Authentication pop-up when you open public link: #6033
When you open public link you have possibility to open a file.txt in "markdown-editor", but if you try do it, you need first log in. this is ok, but the user cannot go back)

Screen.Recording.2021-11-16.at.16.17.46.mov

[kulmann]

Smoke test rc1 against oc10 app

• ✔️ as gunter - upload arch/mips folder from linux kernel (1945 files)

  • progress bar is not sticky
  • expanding the upload progress section slows down browser & upload time significantly

• ✔️ as gunter - share the folder to alice as viewer
  - sharing is not possible before the upload finished (user invite field doesn't stay focussed)

• ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)
  - ❌ as alice, selecting an accepted share, right-click-declining it will not remove it from the selection, leading to weird batch action buttons being displayed

• ✔️ as alice - try do delete file from shared folder
  - individual delete action not visible, good
  - batch delete action not visible, good
  - context menu action not visible, good

• ✔️ as alice - try to add file
  - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

• ❌ as alice - copy 16 folders from share to home

  • no visible feedback that it's in progress
  • UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.
  • folder listing after copy shows ? as folder size on some of the copied folders.

• ✔️ as gunter - add new file to share

• ✔️ as alice - receive new file in existing share

• ✔️ as gunter - unshare folder from shared with others

• ✔️ as alice - try to revisit old share

  • shows resource not found upon page reload, good
  • going back to All files or Shared with me doesn't list the share anymore, good

• ✔️ as gunter - share folder with alice again, but as editor

• ✔️ as alice - rename file

  • via right sidebar, works, good
  • via context menu, works, good

• ✔️ as gunter - add file

• ✔️ as alice - delete file

  • via right sidebar, works, good
  • via context menu, works, good
  • via batch action, works, good

• ✔️ as alice - create public link on any folder

• ✔️ as alice delete file and recover it

• ✔️ as alice create version of textfile

• ✔️ as alice view version history of text file

• ❌ as alice download newest version of text file
  - download as default action in file list (triggered on left click on a file) doesn't work (see remarks below)

• ✔️ download older version of text file

• ✔️ restore older version of text file

  • no visible feedback about the success
  • preview is not updated

• ✔️ as alice - upload avatar in classic UI

  • see own avatar in top bar (far right)
  • login as gunter, having a share with alice
    • shared with others page loads and shows avatars

• ✔️ as alice, move a file into subfolder via drag and drop

• ✔️ as alice, move multiple files & folders into subfolder via drag and drop

• ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Remarks about smoke testing findings from previous release:

• FIXED ✔️ mouse drop event doesn't trigger the upload dropzone anymore. Instead the dropped file opens in a new tab and the web ui shows a successfully moved 0 items message (unchanged, will be fixed in next release). Drag & drop for move kills drag & drop for upload #5808
• FIXED ✔️ coming back from mediaviewer doesn't highlight the selected file anymore in the files list (unchanged)

Findings from new smoke testing:

• selecting an accepted share, right-click-declining it will not remove it from the selection, leading to weird batch action buttons being still displayed. This is not a regression of this release, was broken before. => will be fixed in [full-ci] Prepare batch actions in contextmenu #5973
• download as default action (triggered on left click on a file) doesn't work, because the .handler is called on an array instead of a single action. This is a regression of this release. Easy fix, should be included. Fixed in edb4861 on release branch.